delta/node-new.git/test/parallel/test-crypto-binary-default.js, branch devsnek-patch-1

test: refactor common.expectsError

2019-12-31T14:54:20+00:00

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

test: well-defined DH groups now verify clean

2019-10-01T18:11:18+00:00

OpenSSL 1.1.1d no longer generates warnings for some DH groups that used
to be considered unsafe. See below for discussion. This is considered a
bug fix.

See:
- https://github.com/openssl/openssl/pull/9363
- https://github.com/openssl/openssl/pull/9363#discussion_r324802618

PR-URL: https://github.com/nodejs/node/pull/29550
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen

test: move test_[key|ca|cert] to fixtures/keys/

2019-06-10T16:56:55+00:00

Lots of changes, but mostly just search/replace of
fixtures.readSync(...) to fixtures.readKey([new key]...)

Benchmarks modified to use fixtures.readKey(...):
benchmark/tls/throughput.js
benchmark/tls/tls-connect.js
benchmark/tls/secure-pair.js

Also be sure to review the change to L16 of
test/parallel/test-crypto-sign-verify.js

PR-URL: https://github.com/nodejs/node/pull/27962
Reviewed-By: Sam Roberts 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Rich Trott

test: move dsa keypairs to fixtures/keys/

2019-06-10T16:56:38+00:00

PR-URL: https://github.com/nodejs/node/pull/27962
Reviewed-By: Sam Roberts 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Rich Trott

test: move rsa keypairs to fixtures/keys/

2019-06-10T16:56:33+00:00

Also adds make'd signatures for use in tests of signing/verification.
All of the moved keys can be regenerated at will without breaking tests
now.

PR-URL: https://github.com/nodejs/node/pull/27962
Reviewed-By: Sam Roberts 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Rich Trott

Revert "test: move all test keys/certs under `test/fixtures/keys/`"

2019-06-05T23:01:13+00:00

PR-URL: https://github.com/nodejs/node/pull/28083
Reviewed-By: Anna Henningsen 
Reviewed-By: Ali Ijaz Sheikh 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Refael Ackermann (רפאל פלחי)

test: move test_[key|ca|cert] to fixtures/keys/

2019-06-05T18:37:43+00:00

Lots of changes, but mostly just search/replace of
fixtures.readSync(...) to fixtures.readKey([new key]...)

Benchmarks modified to use fixtures.readKey(...):
benchmark/tls/throughput.js
benchmark/tls/tls-connect.js
benchmark/tls/secure-pair.js

Also be sure to review the change to L16 of
test/parallel/test-crypto-sign-verify.js

PR-URL: https://github.com/nodejs/node/pull/27962
Reviewed-By: Sam Roberts 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Rich Trott

test: move dsa keypairs to fixtures/keys/

2019-06-05T18:37:35+00:00

PR-URL: https://github.com/nodejs/node/pull/27962
Reviewed-By: Sam Roberts 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Rich Trott

test: move rsa keypairs to fixtures/keys/

2019-06-05T18:37:33+00:00

Also adds make'd signatures for use in tests of signing/verification.
All of the moved keys can be regenerated at will without breaking tests
now.

PR-URL: https://github.com/nodejs/node/pull/27962
Reviewed-By: Sam Roberts 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Rich Trott

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso