delta/node-new.git/test/parallel/test-console-table.js, branch devsnek-patch-1

test: refactor common.expectsError

2019-12-31T14:54:20+00:00

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

console: use getStringWidth() for character width calculation

2019-09-02T06:13:58+00:00

This is more accurate for displayed full-width characters
(e.g. CJK ones) and makes the calculations match the ones we
use in the readline module.

Fixes: https://github.com/nodejs/node/issues/29299

PR-URL: https://github.com/nodejs/node/pull/29300
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

console: fix table() output

2019-05-30T06:44:34+00:00

Fixes: https://github.com/nodejs/node/issues/27915

PR-URL: https://github.com/nodejs/node/pull/27917
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat

util: improve function inspection

2019-05-02T21:22:38+00:00

This commit contains the following changes:

1) Add null prototype support for functions.
2) Safely detect async and generator functions.
3) Mark anonymous functions as such instead of just leaving out the
   name.

PR-URL: https://github.com/nodejs/node/pull/27227
Reviewed-By: Joyee Cheung 
Reviewed-By: John-David Dalton 
Reviewed-By: Anto Aravinth 
Reviewed-By: Rich Trott

test: deep object to table not covered

2018-11-15T03:26:56+00:00

PR-URL: https://github.com/nodejs/node/pull/24257
Reviewed-By: Weijia Wang 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater

test: console.table when `null` in data

2018-09-27T03:30:54+00:00

PR-URL: https://github.com/nodejs/node/pull/22974
Reviewed-By: Anna Henningsen 
Reviewed-By: John-David Dalton 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat

console,util: avoid pair array generation in C++

2018-07-16T08:46:09+00:00

Use a plain `[key, value, key, value]`-style list instead
of an array of pairs for inspecting collections.

This also fixes a bug with `console.table()` where
inspecting a non-key-value `MapIterator` would have
led to odd results.

PR-URL: https://github.com/nodejs/node/pull/20831
Refs: https://github.com/nodejs/node/pull/20719#discussion_r189342513
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Gus Caplan 
Reviewed-By: Minwoo Jung 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

test: improve console table error output

2018-07-14T12:04:47+00:00

The former error output was not readable in case of an error. This
improves it by splitting the lines and therefore creating a nice and
readable diff.

PR-URL: https://github.com/nodejs/node/pull/20960
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Michaël Zasso

console: .table fall back to logging for function too

2018-05-18T13:53:06+00:00

According to the console.table documentation, it reads that it "falls
back to just logging the argument if it can’t be parsed as tabular."

But it doesn't fall back when I give a function as its first argument.
It logs an empty table. This is fixes by this commit.

PR-URL: https://github.com/nodejs/node/pull/20681
Fixes: https://github.com/nodejs/node/issues/20679
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

console: fix console.table() display edge case

2018-04-28T06:07:35+00:00

If the properties are not specified in `console.table()`, then we should
make a best effort to determine them rather than put all values into a
"Values" column.

PR-URL: https://github.com/nodejs/node/pull/20323
Reviewed-By: Gus Caplan 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell