delta/node-new.git/test/parallel/test-common.js, branch cleanup-getnodeversion.py

test: regression test `tmpdir`

2019-06-06T23:38:34+00:00

PR-URL: https://github.com/nodejs/node/pull/28035
Reviewed-By: Rich Trott 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Sam Roberts

test: allow leaked global check to be skipped

2019-04-19T03:45:04+00:00

This simplifies the process of running tests on different
versions of Node, which might have a different set of
global variables.

PR-URL: https://github.com/nodejs/node/pull/27239
Reviewed-By: Rich Trott 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

test: rename process.argv[0] to process.execPath, rename ex to err

2018-10-15T10:00:00+00:00

PR-URL: https://github.com/nodejs/node/pull/23488
Reviewed-By: Colin Ihrig 
Reviewed-By: Bryan English 
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

test: do not export common.leakedGlobals()

2018-09-22T02:20:26+00:00

common.leakedGlobals() was exposed only to test its logic. The logic can
instead be tested by running a fixture file that leaks a global and
seeing if `common` causes an AssertionError on exit. This way, the
entire functionality of leak detection is tested rather than just the
leakedGlobals() function. It also reduces API surface area for the
common monolith by one function.

PR-URL: https://github.com/nodejs/node/pull/22965
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: James M Snell

test: move hijackstdio out of require('common')

2018-08-24T16:53:58+00:00

Move the hijackstdio functions out of common so that they are
imported only into the tests that actually need them

PR-URL: https://github.com/nodejs/node/pull/22462
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Refael Ackermann 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca

test: use common.expectsError in tests

2017-12-08T21:21:47+00:00

PR-URL: https://github.com/nodejs/node/pull/17484
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Jon Moss

test: replace fixtureDir with fixtures.path

2017-10-10T04:18:11+00:00

PR-URL: https://github.com/nodejs/node/pull/15943
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

test: fix hijackStdout behavior in console

2017-08-29T17:48:53+00:00

`console.log` and some other function will swallow the exception in
`stdout.write`. So an asynchronous exception is needed, or
`common.hijackStdout` won't detect some exception.

Refs: https://github.com/nodejs/node/blob/v8.2.1/lib/console.js#L87

PR-URL: https://github.com/nodejs/node/pull/14647
Reviewed-By: James M Snell 
Reviewed-By: Refael Ackermann 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Joyee Cheung

lib,src: fix consistent spacing inside braces

2017-07-21T19:13:47+00:00

PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Refael Ackermann 
Reviewed-By: Timothy Gu 
Reviewed-By: James M Snell