delta/node-new.git/test/parallel/test-cluster-basic.js, branch devsnek-patch-1

tools: add 'spaced-comment' into eslint rules

2018-04-01T14:33:13+00:00

PR-URL: https://github.com/nodejs/node/pull/19596
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Sakthipriyan Vairamani

test: add missing spaces in concatenations

2017-10-17T09:41:03+00:00

PR-URL: https://github.com/nodejs/node/pull/16244
Reviewed-By: Yuta Hiroto 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Luigi Pinca

test: add NODE_UNIQUE_ID value to err message

2017-10-09T09:13:17+00:00

PR-URL: https://github.com/nodejs/node/pull/15914
Reviewed-By: Daijiro Wachi 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Ruben Bridgewater

test: refactor test-cluster-basic

2017-06-29T03:04:40+00:00

* Use common.mustNotCall() to check that callback is not invoked.
* Add space per test writing guide.

PR-URL: https://github.com/nodejs/node/pull/13905
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yuta Hiroto 
Reviewed-By: James M Snell

test: remove common.PORT from test-cluster-basic

2017-04-15T05:08:58+00:00

Use of `common.PORT` in `parallel` tests is not completely safe (because
the same port can be previously assigned to another test running in
parallel if that test uses port `0` to get an arbitrary available port).

Remove `common.PORT` from test-cluster-basic.

PR-URL: https://github.com/nodejs/node/pull/12377
Reviewed-By: Richard Lau 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

test: add common.noop, default for common.mustCall()

2017-03-26T19:47:15+00:00

Export a new common.noop no-operation function for general use.
Allow using common.mustCall() without a fn argument to simplify
test cases.

Replace various non-op functions throughout tests with common.noop

PR-URL: https://github.com/nodejs/node/pull/12027
Reviewed-By: Jeremiah Senkpiel 
Reviewed-By: Richard Lau 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Teddy Katz 
Reviewed-By: Colin Ihrig 
Reviewed-By: Franziska Hinkelmann

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

test: refactor/cleanup a number of cluster tests

2016-09-01T14:13:47+00:00

* Move shared code into common
* Favor use of strictEqual
* Add some missing common.mustCalls
* Other general cleanup

PR-URL: https://github.com/nodejs/node/pull/8261
Reviewed-By: Santiago Gimeno

lib,benchmark,test: implement consistent braces

2016-07-12T17:33:29+00:00

This change is in preparation for lint-enforced brace style.

PR-URL: https://github.com/nodejs/node/pull/7630
Reviewed-By: Brian White 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Roman Reiss 
Reviewed-By: Trevor Norris 
Reviewed-By: Rod Vagg