delta/node-new.git/test/parallel/test-child-process-spawnsync-timeout.js, branch devsnek-patch-1

test: refactoring / cleanup on child-process tests

2020-03-24T18:21:00+00:00

PR-URL: https://github.com/nodejs/node/pull/32078
Reviewed-By: Gireesh Punathil

lib: correct error.errno to always be numeric

2019-06-17T02:18:09+00:00

Historically `error.errno` of system errors thrown by Node.js
can sometimes be the same as `err.code`, which are string
representations of the error numbers. This is useless and incorrect,
and results in an information loss for users since then they
will have to resort to something like
`process.binding('uv'[`UV_${errno}`])` to get to the numeric
error codes.

This patch corrects this behavior by always setting `error.errno`
to be negative numbers. For fabricated errors like `ENOTFOUND`,
`error.errno` is now undefined since there is no numeric equivalent
for them anyway. For c-ares errors, `error.errno` is now undefined
because the numeric representations (negated) can be in conflict
with libuv error codes - this is fine since numeric codes was
not available for c-ares errors anyway.

Users can use the public API `util.getSystemErrorName(errno)`
to retrieve string codes for these numbers.

PR-URL: https://github.com/nodejs/node/pull/28140
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat

test: adjust indentation for stricter linting

2017-07-27T16:24:20+00:00

ESLint 4.x has stricter linting than previous versions. We are currently
using the legacy indentation rules in the test directory. This commit
changes the indentation of files to comply with the stricter 4.x linting
and enable stricter linting in the test directory.

PR-URL: https://github.com/nodejs/node/pull/14431
Reviewed-By: Refael Ackermann 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Trevor Norris

lib,src: fix consistent spacing inside braces

2017-07-21T19:13:47+00:00

PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Refael Ackermann 
Reviewed-By: Timothy Gu 
Reviewed-By: James M Snell

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

test: allow for slow hosts in spawnSync() test

2017-01-27T20:03:06+00:00

test-child-process-spawnsync-timeout failed from time to time on
Raspberry Pi devices. Use common.platformTimeout() to allow a little
more time to run on resource-constrained hosts.

PR-URL: https://github.com/nodejs/node/pull/10998
Reviewed-By: Colin Ihrig 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Anna Henningsen 
Reviewed-By: Luigi Pinca

test: use eslint to fix var->const/let

2017-01-11T11:43:52+00:00

Manually fix issues that eslint --fix couldn't do automatically.

PR-URL: https://github.com/nodejs/node/pull/10685
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Roman Reiss

test: use const for all require() calls

2017-01-02T23:28:18+00:00

PR-URL: https://github.com/nodejs/node/pull/10550
Reviewed-By: Rich Trott

test: remove unnecessary assignments

2015-12-27T02:00:02+00:00

common.js needs to be loaded in all tests so that there is checking
for variable leaks and possibly other things. However, it does not
need to be assigned to a variable if nothing in common.js is referred
to elsewhere in the test.

PR-URL: https://github.com/nodejs/node/pull/4408
Reviewed-By: James M Snell

test: enable linting for tests

2015-05-19T19:21:27+00:00

Enable linting for the test directory. A number of changes was made so
all tests conform the current rules used by lib and src directories. The
only exception for tests is that unreachable (dead) code is allowed.

test-fs-non-number-arguments-throw had to be excluded from the changes
because of a weird issue on Windows CI.

PR-URL: https://github.com/nodejs/io.js/pull/1721
Reviewed-By: Ben Noordhuis