delta/node-new.git/test/parallel/test-child-process-exec-kill-throws.js, branch Remove-Python-3-tests

test: fix flaky child-process-exec-kill-throws

2018-04-26T06:45:57+00:00

Kill the child process with `SIGKILL` to make sure the child process
does not remain alive.

Fixes: https://github.com/nodejs/node/issues/20139

PR-URL: https://github.com/nodejs/node/pull/20213
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Weijia Wang 
Reviewed-By: James M Snell

test: make the rest of tests path-independent

2017-05-14T13:05:48+00:00

Permit spaces in paths to a Node.js executable and test scripts.

PR-URL: https://github.com/nodejs/node/pull/12972
Fixes: https://github.com/nodejs/node/issues/12773
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

test: fix flaky child-process-exec-kill-throws

2017-03-31T05:49:19+00:00

This is a fix for test-child-process-exec-kill-throws which is currently
flaky on Windows.

A bug in the test was causing the child process to fail for reasons
other than those intended by the test. Instead of failing for exceeding
the `maxBuffer` setting, the test was failing because it was trying to
load `internal/child_process` without being passed the
`expose-internals` flag. Move that module to where only the parent
process (which gets the flag) loads it.

Additionally, improve an assertion message to help debug problems like
this.

PR-URL: https://github.com/nodejs/node/pull/12111
Fixes: https://github.com/nodejs/node/issues/12053
Reviewed-By: Richard Lau

test: cover thrown errors from exec() kill

2017-03-26T10:29:17+00:00

This commit adds code coverage for the scenario where exec()
kills a child process, but the call to ChildProcess#kill()
throws an exception.

PR-URL: https://github.com/nodejs/node/pull/11038
Reviewed-By: Sam Roberts 
Reviewed-By: James M Snell 
Reviewed-By: Franziska Hinkelmann