delta/node-new.git/test/parallel/test-buffer-writeuint.js, branch devsnek-patch-1

test: adjust comments for upcoming lint rule

2020-10-07T11:36:02+00:00

Enforce `//` for multiline comments. Some tests mixed and matched, and
at least one did so in a (to me) surprising way.

PR-URL: https://github.com/nodejs/node/pull/35485
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

buffer: also alias BigUInt methods

2020-09-02T14:22:35+00:00

These were overlooked in 5864fca7bc96b because of the extra
`Big` in the name. :)

Refs: https://github.com/nodejs/node/pull/34729

PR-URL: https://github.com/nodejs/node/pull/34960
Reviewed-By: Richard Lau 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: Luigi Pinca

buffer: alias UInt ➡️ Uint in buffer methods

2020-08-14T02:57:39+00:00

It’s *so* hard to remember that it’s `UintXArray` but not
`(write|read)UintX`. Let’s fix that by just providing aliases. 😊

PR-URL: https://github.com/nodejs/node/pull/34729
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott

buffer: fix 6-byte writeUIntBE() range check

2019-11-30T03:40:52+00:00

Fixes: https://github.com/nodejs/node/issues/30420

PR-URL: https://github.com/nodejs/node/pull/30459
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

buffer,errors: improve bigint, big numbers and more

2019-05-01T10:29:04+00:00

This improves the error message from `ERR_OUT_OF_RANGE` by closer
inspecting the value and logging numbers above 2 ** 32 by adding
commas to the output for integer and bigint. BigInt is now also
marked if used.

Buffer errors also format the range as 2 ** n instead of showing a
huge number.

PR-URL: https://github.com/nodejs/node/pull/27228
Reviewed-By: Richard Lau 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Michaël Zasso

errors: update error name

2019-03-23T01:55:54+00:00

This updates all Node.js errors by removing the `code` being part
of the `name` property. Instead, the name is just changed once on
instantiation, the stack is accessed to create the stack as expected
and then the `name` property is set back to it's original form.

PR-URL: https://github.com/nodejs/node/pull/26738
Fixes: https://github.com/nodejs/node/issues/26669
Fixes: https://github.com/nodejs/node/issues/20253
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung

buffer: fix writeUInt16BE range check

2018-11-08T23:22:19+00:00

Fixes: https://github.com/nodejs/node/issues/24205

PR-URL: https://github.com/nodejs/node/pull/24208
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen

test: improve internal/buffer.js test coverage

2018-06-04T15:44:28+00:00

Added tests buffer.js methods to write 48 bit value to
improve test coverage.

PR-URL: https://github.com/nodejs/node/pull/21061
Reviewed-By: Weijia Wang 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Lance Ball

buffer: do not always use defaults

2018-04-29T14:52:46+00:00

The Buffer#(read|write)U?Int(B|L)E functions should not use a default
value. This is very likely a bug and it was never documented that
way.

Besides that this also improves the tests by adding more tests and by
refactoring them to less code lines.

PR-URL: https://github.com/nodejs/node/pull/20054
Reviewed-By: Anna Henningsen 
Reviewed-By: Khaidi Chu 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Сковорода Никита Андреевич

buffer: use a default offset

2018-04-13T17:58:26+00:00

If none is provided, use zero as a default offset for all read/write
operations on the buffer.

PR-URL: https://github.com/nodejs/node/pull/19749
Refs: https://github.com/nodejs/node/pull/18395
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen