delta/node-new.git/test/parallel/test-buffer-read.js, branch cleanup-getnodeversion.py

buffer: improve ERR_BUFFER_OUT_OF_BOUNDS default

2019-08-14T22:24:34+00:00

This commit changes the default message used by
ERR_BUFFER_OUT_OF_BOUNDS. Previously, the default
message implied that the problematic was always a
write, which is not accurate.

PR-URL: https://github.com/nodejs/node/pull/29098
Fixes: https://github.com/nodejs/node/issues/29097
Reviewed-By: Anna Henningsen 
Reviewed-By: Sam Roberts 
Reviewed-By: Jiawen Geng 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Rich Trott

errors: update error name

2019-03-23T01:55:54+00:00

This updates all Node.js errors by removing the `code` being part
of the `name` property. Instead, the name is just changed once on
instantiation, the stack is accessed to create the stack as expected
and then the `name` property is set back to it's original form.

PR-URL: https://github.com/nodejs/node/pull/26738
Fixes: https://github.com/nodejs/node/issues/26669
Fixes: https://github.com/nodejs/node/issues/20253
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

test: fixed error message in test-buffer-read

2018-10-31T19:59:13+00:00

PR-URL: https://github.com/nodejs/node/pull/23957
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat

buffer: do not always use defaults

2018-04-29T14:52:46+00:00

The Buffer#(read|write)U?Int(B|L)E functions should not use a default
value. This is very likely a bug and it was never documented that
way.

Besides that this also improves the tests by adding more tests and by
refactoring them to less code lines.

PR-URL: https://github.com/nodejs/node/pull/20054
Reviewed-By: Anna Henningsen 
Reviewed-By: Khaidi Chu 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Сковорода Никита Андреевич

buffer: refactor all read/write functions

2018-03-02T19:29:46+00:00

There are a lot of changes in this commit:

1) Remove the `noAssert` argument from all read and write functions.
2) Improve the performance of all read floating point functions
   significantly. This is done by switching to TypedArrays as the
   write floating point write functions.
3) No implicit type coercion for offset and byteLength anymore.
4) Adds a lot of tests.
5) Moves the read and write functions to the internal buffer file
   to split the files in smaller chunks.
6) Reworked a lot of existing tests.
7) Improve the performane of all all read write functions by using
   a faster input validation and by improving function logic.
8) Significantly improved the performance of all read int functions.
   This is done by using a implementation without a loop.
9) Improved error handling.
10) Rename test file to use the correct subsystem.

PR-URL: https://github.com/nodejs/node/pull/18395
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Ben Noordhuis

test: remove assert.doesNotThrow()

2018-02-16T15:53:47+00:00

There is actually no reason to use `assert.doesNotThrow()` in the
tests. If a test throws, just let the error bubble up right away
instead of first catching it and then rethrowing it.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina