delta/node-new.git/test/parallel/test-buffer-copy.js, branch cleanup-getnodeversion.py

buffer: improve copy() performance

2019-08-14T22:59:32+00:00

PR-URL: https://github.com/nodejs/node/pull/29066
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

benchmark,doc,lib: capitalize more comments

2019-03-27T16:20:06+00:00

PR-URL: https://github.com/nodejs/node/pull/26849
Reviewed-By: Rich Trott 
Reviewed-By: Vse Mozhet Byt

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

buffer: fix crash for invalid index types

2018-12-31T00:13:00+00:00

2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a introduced a crash
when a non-number value was passed to `ParseArrayIndex()`.

We do not always have JS typechecking for that in place, though.
This returns back to the previous behavior of coercing values
to integers, which is certainly questionable.

Refs: https://github.com/nodejs/node/pull/22129
Fixes: https://github.com/nodejs/node/issues/23668

PR-URL: https://github.com/nodejs/node/pull/25154
Reviewed-By: James M Snell

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

tools: capitalize sentences

2018-12-10T16:07:18+00:00

This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.

PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Sakthipriyan Vairamani

test: add property for RangeError in test-buffer-copy

2018-11-02T02:50:37+00:00

PR-URL: https://github.com/nodejs/node/pull/23968
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Colin Ihrig

test: swap arguments in strictEqual()

2018-10-06T12:39:37+00:00

Swap arguments in strictEqual() for parallel/test-buffer-copy.

PR-URL: https://github.com/nodejs/node/pull/23204
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell

test: minor refactoring

2018-02-16T15:54:07+00:00

Add punctuation and comments about code that should not throw.
Also remove a obsolete test and refactor some tests.

PR-URL: https://github.com/nodejs/node/pull/18669
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina