tools: force common be required before any other modules

2019-05-13T11:39:34+00:00

PR-URL: https://github.com/nodejs/node/pull/27650
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ruben Bridgewater

buffer: do deprecation warning outside `node_modules`

2018-04-09T22:43:41+00:00

In addition to `--pending-deprecation`, emit a deprecation warning
for usage of the `Buffer()` constructor for call sites that are outside
of `node_modules`.

The goal of this is to better target developers, rather than
burdening users with an omnipresent and quickly ignored warning.

This implements the result of a TSC meeting discussion
from March 22, 2018.

PR-URL: https://github.com/nodejs/node/pull/19524
Refs: https://github.com/nodejs/node/issues/19079#issuecomment-375121443
Reviewed-By: Rich Trott 
Reviewed-By: Rod Vagg 
Reviewed-By: Michaël Zasso 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Colin Ihrig 
Reviewed-By: Evan Lucas 
Reviewed-By: Myles Borins

delta/node-new.git/test/parallel/test-buffer-constructor-outside-node-modules.js, branch cleanup-getnodeversion.py

tools: force common be required before any other modules

buffer: do deprecation warning outside `node_modules`