delta/node-new.git/test/parallel/test-buffer-bytelength.js, branch Remove-Python-3-tests

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth

doc,lib,test: capitalize comment sentences

2018-12-17T16:14:35+00:00

This activates the eslint capitalize comment rule for comments
above 50 characters.

PR-URL: https://github.com/nodejs/node/pull/24996
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell

lib: improve the usage of TypeError[INVALID_ARG_TYPE]

2017-11-12T19:04:06+00:00

The initials of expected in TypeError[ERR_INVALID_ARG_TYPE]
are inconsistent. This change is to unify them.

PR-URL: https://github.com/nodejs/node/pull/16401
Fixes: https://github.com/nodejs/node/issues/16383
Reviewed-By: Joyee Cheung 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum

buffer: improve error messages

2017-08-24T21:49:47+00:00

Some errors in buffer module losed some arguments or received
wrong arguments when they were created. This PR added these
losing arguments and fixed the wrong arguments.

PR-URL: https://github.com/nodejs/node/pull/14975
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina

errors,buffer: port errors to internal/errors

2017-07-12T21:00:30+00:00

PR-URL: https://github.com/nodejs/node/pull/13976
Reviewed-By: Refael Ackermann 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum

test: remove require('buffer') from 4 buffer tests

2017-06-24T01:32:30+00:00

Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: https://github.com/nodejs/node/issues/13836
PR-URL: https://github.com/nodejs/node/pull/13855
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Alexey Orlenko 
Reviewed-By: James M Snell

test: fix RegExp nits

2017-06-21T00:40:27+00:00

* Remove needless RegExp flag

  In fixed case, `/g` flag is needless in the boolean context.

* Remove needless RegExp capturing

  Use non-capturing grouping or remove capturing completely when:

  * capturing is useless per se, e.g. in test() check;
  * captured groups are not used afterward at all;
  * some of the later captured groups are not used afterward.

* Use test, not match/exec in boolean context

  match() and exec() return a complicated object,
  unneeded in a boolean context.

* Do not needlessly repeat RegExp creation

  This commit takes RegExp creation out of cycles and other repetitions.

  As long as the RegExp does not use /g flag and match indices,
  we are safe here.

  In tests, this fix hardly gives a significant performance gain,
  but it increases clarity and maintainability,
  reassuring some RegExps to be identical.

  RegExp in functions are not taken out of their functions:
  while these functions are called many times
  and their RegExps are recreated with each call,
  the performance gain in test cases
  does not seem to be worth decreasing function self-dependency.

PR-URL: https://github.com/nodejs/node/pull/13770
Reviewed-By: Colin Ihrig

test: complete coverage of buffer

2017-05-07T20:20:33+00:00

PR-URL: https://github.com/nodejs/node/pull/12831
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Alexey Orlenko 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum

test: increase coverage of buffer

2017-05-03T02:35:56+00:00

Increase coverage of lib/buffer.js.

PR-URL: https://github.com/nodejs/node/pull/12714
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson