delta/node-new.git/test/parallel/test-buffer-arraybuffer.js, branch devsnek-patch-1

errors: improve ERR_INVALID_ARG_TYPE

2019-12-20T02:10:13+00:00

ERR_INVALID_ARG_TYPE is the most common error used throughout the
code base. This improves the error message by providing more details
to the user and by indicating more precisely which values are allowed
ones and which ones are not.

It adds the actual input to the error message in case it's a primitive.
If it's a class instance, it'll print the class name instead of
"object" and "falsy" or similar entries are not named "type" anymore.

PR-URL: https://github.com/nodejs/node/pull/29675
Reviewed-By: Rich Trott

errors: update error name

2019-03-23T01:55:54+00:00

This updates all Node.js errors by removing the `code` being part
of the `name` property. Instead, the name is just changed once on
instantiation, the stack is accessed to create the stack as expected
and then the `name` property is set back to it's original form.

PR-URL: https://github.com/nodejs/node/pull/26738
Fixes: https://github.com/nodejs/node/issues/26669
Fixes: https://github.com/nodejs/node/issues/20253
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung

test: check codes of thrown errors

2018-10-18T03:49:39+00:00

PR-URL: https://github.com/nodejs/node/pull/23519
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: George Adams

errors: validate input arguments

2018-04-13T17:59:44+00:00

This makes sure the input arguments get validated so implementation
errors will be caught early. It also improves a couple of error
messages by providing more detailed information and fixes errors
detected by the new functionality. Besides that a error type got
simplified and tests got refactored.

PR-URL: https://github.com/nodejs/node/pull/19924
Reviewed-By: Michaël Zasso 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell

tools: add 'spaced-comment' into eslint rules

2018-04-01T14:33:13+00:00

PR-URL: https://github.com/nodejs/node/pull/19596
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Sakthipriyan Vairamani

buffer: refactor all read/write functions

2018-03-02T19:29:46+00:00

There are a lot of changes in this commit:

1) Remove the `noAssert` argument from all read and write functions.
2) Improve the performance of all read floating point functions
   significantly. This is done by switching to TypedArrays as the
   write floating point write functions.
3) No implicit type coercion for offset and byteLength anymore.
4) Adds a lot of tests.
5) Moves the read and write functions to the internal buffer file
   to split the files in smaller chunks.
6) Reworked a lot of existing tests.
7) Improve the performane of all all read write functions by using
   a faster input validation and by improving function logic.
8) Significantly improved the performance of all read int functions.
   This is done by using a implementation without a loop.
9) Improved error handling.
10) Rename test file to use the correct subsystem.

PR-URL: https://github.com/nodejs/node/pull/18395
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Ben Noordhuis

buffer: remove obsolete NaN check

2018-02-16T17:09:55+00:00

These two NaN entries are not necessary and we can safely remove them.

PR-URL: https://github.com/nodejs/node/pull/18744
Reviewed-By: Weijia Wang 
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Luigi Pinca

test: replace assert.throws w/ common.expectsError

2017-12-08T21:23:32+00:00

PR-URL: https://github.com/nodejs/node/pull/17483
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: Evan Lucas 
Reviewed-By: James M Snell

errors,buffer: port errors to internal/errors

2017-07-12T21:00:30+00:00

PR-URL: https://github.com/nodejs/node/pull/13976
Reviewed-By: Refael Ackermann 
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum

test: remove require('buffer') from 4 buffer tests

2017-06-24T01:32:30+00:00

Remove superfluous import from:

* test/parallel/test-buffer-alloc.js
* test/parallel/test-buffer-arraybuffer.js
* test/parallel/test-buffer-badhex.js
* test/parallel/test-buffer-bytelength.js

Refs: https://github.com/nodejs/node/issues/13836
PR-URL: https://github.com/nodejs/node/pull/13855
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Alexey Orlenko 
Reviewed-By: James M Snell