delta/node-new.git/test/parallel/test-assert.js, branch test

test: prepare for consistent comma-dangle lint rule

2021-04-02T06:14:29+00:00

Make changes so that tests will pass when the comma-dangle settings
applied to the rest of the code base are also applied to tests.

PR-URL: https://github.com/nodejs/node/pull/37930
Reviewed-By: James M Snell 
Reviewed-By: Derek Lewis

tools: upgrade to @babel/eslint-parser 7.12.1

2020-12-07T18:05:29+00:00

PR-URL: https://github.com/nodejs/node/pull/36321
Fixes: https://github.com/ensure
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

assert: align character indicators properly

2020-02-09T12:39:54+00:00

This makes sure color codes are not taken into account in case
util.inspect's default value was changed.

PR-URL: https://github.com/nodejs/node/pull/31429
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Anna Henningsen

test: improve logged errors

2020-02-09T12:36:39+00:00

To indicate which lines are test lines and which from Node.js core,
it's good to rely on `util.inspect()` while inspecting errors.

The stack was accessed directly instead in multiple cases and logging
that does not provide as much information as using `util.inspect()`.

PR-URL: https://github.com/nodejs/node/pull/31425
Reviewed-By: Rich Trott 
Reviewed-By: Anto Aravinth 
Reviewed-By: James M Snell 
Reviewed-By: Yihong Wang

assert: implement `assert.match()` and `assert.doesNotMatch()`

2020-01-01T17:44:31+00:00

This adds a new functionality to the assertion module: a dedicated
check for regular expressions. So far it's possible to use
`assert.ok(regexp.test(string))`. This is not ideal though when it
comes to the error message, since it's not possible to know how
either of the input values look like. It's just known that the
assertion failed.
This allows to pass through the regular expression and the input
string. The string is then matched against the regular expression
and reports a expressive error message in case of a failure.

PR-URL: https://github.com/nodejs/node/pull/30929
Reviewed-By: Michaël Zasso 
Reviewed-By: Rich Trott 
Reviewed-By: Stephen Belanger

test: refactor common.expectsError

2019-12-31T14:54:20+00:00

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

errors: improve ERR_INVALID_ARG_TYPE

2019-12-20T02:10:13+00:00

ERR_INVALID_ARG_TYPE is the most common error used throughout the
code base. This improves the error message by providing more details
to the user and by indicating more precisely which values are allowed
ones and which ones are not.

It adds the actual input to the error message in case it's a primitive.
If it's a class instance, it'll print the class name instead of
"object" and "falsy" or similar entries are not named "type" anymore.

PR-URL: https://github.com/nodejs/node/pull/29675
Reviewed-By: Rich Trott

assert: handle (deep) equal(NaN, NaN) as being identical

2019-12-06T23:43:51+00:00

This aligns the `equal` and `deepEqual()` implementations with the
strict versions by accepting `NaN` as being identical in case both
sides are NaN.

Refs: https://github.com/nodejs/node/issues/30350#issuecomment-552191641

PR-URL: https://github.com/nodejs/node/pull/30766
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko 
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott

assert: special handle identical error names in instance checks

2019-10-01T20:56:01+00:00

This makes sure that using `assert.throws()` or `assert.rejects()`
in combination with Error classes log appropriate error messages
in case the expected and received constructor name are identical
but not part of the same prototype chain.

PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell

assert: add more information to AssertionErrors

2019-10-01T20:56:01+00:00

This adds information about the actual thrown error to the
AssertionError's message property.

It also improves the logged error instances error name by using the
constructors name, if available.

PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell