delta/node-new.git/test/parallel/test-assert.js, branch Remove-Python-3-tests

assert: avoid potentially misleading reference to object identity

2019-07-26T05:36:29+00:00

Often, the word “identical” when referring to JS objects will
be read as referring to having the same object identity (which is
called “reference equality” here), but what the error message is
trying to say here is that the objects are different but yield the
same `util.inspect()` output.

Since `util.inspect()` output represents the structure rather than
the identity of objects, (hopefully) clarify the error message to
reflect that.

PR-URL: https://github.com/nodejs/node/pull/28824
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

test: add test to doesNotThrow; validate if actual with regex

2019-07-01T22:40:07+00:00

Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L736

PR-URL: https://github.com/nodejs/node/pull/28355
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat

test: add tests to assert.ok and improve coverage

2019-07-01T22:40:01+00:00

Refs: https://coverage.nodejs.org/coverage-1a4f27ae21698d0c/lib/assert.js.html#L364

PR-URL: https://github.com/nodejs/node/pull/28355
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat

test: check custom inspection truncation in assert

2019-06-18T18:16:26+00:00

The assert module has some truncation logic in a custom inspect
function. This was not covered in tests. Add tests to cover it.

PR-URL: https://github.com/nodejs/node/pull/28234
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Daniel Bevenius

assert: add partial support for evaluated code in simple assert

2019-06-13T03:02:50+00:00

This makes sure using `assert.ok()` in `new Function()` statements
visualizes the actual call site in the error message.

PR-URL: https://github.com/nodejs/node/pull/27781
Reviewed-By: Rich Trott

assert: improve regular expression validation

2019-06-13T03:02:48+00:00

This makes sure `assert.throws()` and `assert.rejects()` result in
an easy to understand error message instead of rethrowing the actual
error. This should significantly improve the debugging experience in
case people use an regular expression to validate their errors.

This also adds support for primitive errors that would have caused
runtime errors using the mentioned functions. The input is now
stringified before it's passed to the RegExp to circumvent that.

As drive-by change this also adds some further comments and renames
a variable for clarity.

PR-URL: https://github.com/nodejs/node/pull/27781
Reviewed-By: Rich Trott

assert: print more lines in the error diff

2019-06-13T02:50:03+00:00

So far consequitive identical lines were collapsed if there were at
least three. Now they are only collapsed from five identical lines on.

This also simplifies the implementation a tiny bit by abstracting some
logic.

PR-URL: https://github.com/nodejs/node/pull/28058
Reviewed-By: Rich Trott

util: include reference anchor for circular structures

2019-05-20T12:20:59+00:00

This adds a reference anchor to circular structures when using
`util.inspect`. That way it's possible to identify with what object
the circular reference corresponds too.

PR-URL: https://github.com/nodejs/node/pull/27685
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Rich Trott 
Reviewed-By: Anto Aravinth 
Reviewed-By: James M Snell 
Reviewed-By: Jeremiah Senkpiel

assert: add compatibility for older Node.js versions

2019-05-16T10:52:49+00:00

This makes sure the `AssertionError` still accepts the
`stackStartFunction` option as alternative to the `stackStartFn`.

PR-URL: https://github.com/nodejs/node/pull/27672
Fixes: https://github.com/nodejs/node/issues/27671
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Anto Aravinth 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat

assert: refine assertion message

2019-05-05T21:44:19+00:00

This makes sure that the error message is more appropriate than
before by checking closer what operator is used and which is not.

It also increases the total number of lines printed to the user.

PR-URL: https://github.com/nodejs/node/pull/27525
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso