delta/node-new.git/test/parallel/test-assert-fail.js, branch cleanup-getnodeversion.py

assert: fix `assert.fail()` stack

2019-05-05T21:44:17+00:00

This makes sure the error message visible in the error stack created
when using `assert.fail()` without any arguments or the message set
to `undefined` or `null` as only argument.
That was masked before due to other changes.

PR-URL: https://github.com/nodejs/node/pull/27525
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso

errors: update error name

2019-03-23T01:55:54+00:00

This updates all Node.js errors by removing the `code` being part
of the `name` property. Instead, the name is just changed once on
instantiation, the stack is accessed to create the stack as expected
and then the `name` property is set back to it's original form.

PR-URL: https://github.com/nodejs/node/pull/26738
Fixes: https://github.com/nodejs/node/issues/26669
Fixes: https://github.com/nodejs/node/issues/20253
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung

assert: add default operator to `assert.fail()`

2018-09-17T13:59:12+00:00

This makes sure `assert.fail()` contains an operator instead of being
undefined.

On top of that it also fixes the `err.generatedMessage` property.
Before, it was not always set correct.

PR-URL: https://github.com/nodejs/node/pull/22694
Reviewed-By: John-David Dalton 
Reviewed-By: Matteo Collina

assert: improve assert.throws

2018-03-25T01:10:15+00:00

This switches the assert.throws output to the one used in strict mode
if a error object is used for comparison. From now on it will show
the complete difference between two objects instead of only showing
the first failing property.

It also fixes detecting properties with a undefined value and fails
in case the thrown error does not contain the value at all.

PR-URL: https://github.com/nodejs/node/pull/19463
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell

assert: deprecate assert.fail partially

2018-02-02T18:05:22+00:00

Using `assert.fail()` with more than one argument is not intuitive
to use and has no benefit over using a message on its own.

Therefore this introduces a runtime deprecation in case it is used
in that way.

PR-URL: https://github.com/nodejs/node/pull/18418
Reviewed-By: Luigi Pinca 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Matteo Collina

test: replace assert.throws w/ common.expectsError

2017-12-11T23:21:58+00:00

PR-URL: https://github.com/nodejs/node/pull/17557
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig

assert: support custom errors

2017-09-12T19:02:00+00:00

This commit adds special handling of Error instances when passed
as the message argument to assert functions. With this commit,
if an Error is passed as the message, then that Error is thrown
instead of an AssertionError.

PR-URL: https://github.com/nodejs/node/pull/15304
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater

test: fix error when foo in path to git clone

2017-07-30T11:05:44+00:00

I fixed an error that occured in the test case of the file
test/parallel/test-assert-fail.js when foo was in the path to
the git clone. This occured due to a regex that looked only for the
word foo, and so it was updated to not look for foo/, but only
foo. This way it won't go off from foo being in the path to the
git clone

PR-URL: https://github.com/nodejs/node/pull/14506
Reviewed-By: Luigi Pinca 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Vse Mozhet Byt

test: add optional throw fn to expectsError

2017-07-08T20:00:57+00:00

PR-URL: https://github.com/nodejs/node/pull/14089
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Tobias Nießen 
Reviewed-By: Refael Ackermann

assert: refactor the code

2017-07-03T02:44:09+00:00

1. Rename private functions
2. Use destructuring
3. Remove obsolete comments

PR-URL: https://github.com/nodejs/node/pull/13862
Reviewed-By: Refael Ackermann 
Reviewed-By: Joyee Cheung