delta/node-new.git/test/parallel/test-assert-async.js, branch devsnek-patch-1

errors: improve ERR_INVALID_ARG_TYPE

2019-12-20T02:10:13+00:00

ERR_INVALID_ARG_TYPE is the most common error used throughout the
code base. This improves the error message by providing more details
to the user and by indicating more precisely which values are allowed
ones and which ones are not.

It adds the actual input to the error message in case it's a primitive.
If it's a class instance, it'll print the class name instead of
"object" and "falsy" or similar entries are not named "type" anymore.

PR-URL: https://github.com/nodejs/node/pull/29675
Reviewed-By: Rich Trott

assert: add more information to AssertionErrors

2019-10-01T20:56:01+00:00

This adds information about the actual thrown error to the
AssertionError's message property.

It also improves the logged error instances error name by using the
constructors name, if available.

PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell

assert: wrap validation function errors

2019-10-01T20:55:11+00:00

This makes sure that validation function used by `assert.throws` and
`assert.rejects` always throw validatin errors instead of rethrowing
the received error.

That should improve the debugging experience for developers since
they have a better context where the error is coming from and they
also get to know what triggered it.

PR-URL: https://github.com/nodejs/node/pull/28263
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell

tools: prohibit `assert.doesNotReject()` in Node.js core

2019-04-27T16:22:27+00:00

This makes sure we do not use `assert.doesNotReject()` anywhere in
our code base. This is just a simple wrapper that catches the
rejection and then rejects it again in case of an error. Thus, it is
not useful to do that.

The error message for `assert.doesNotThrow()` is also improved.

PR-URL: https://github.com/nodejs/node/pull/27402
Reviewed-By: Rich Trott 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Beth Griggs 
Reviewed-By: James M Snell

test: cover thenables when we check for promises

2019-04-10T21:37:41+00:00

Added tests that cover the issue when assert.rejects() and
assert.doesNotReject() should not accept Thenables without
a `catch` method or any Thenable function with `catch` and
`then` methods attached.

PR-URL: https://github.com/nodejs/node/pull/24219
Reviewed-By: Ruben Bridgewater

assert: fix rejects stack trace and operator

2019-04-07T18:25:32+00:00

This makes sure the stack trace is not removed due to a wrong stack
start function being used. It also fixes the wrong operator caused
by the same reason. This only applies in case an validation object
was used to validate the rejection passed to `assert.reject()` as
first argument.

PR-URL: https://github.com/nodejs/node/pull/27047
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

errors: update error name

2019-03-23T01:55:54+00:00

This updates all Node.js errors by removing the `code` being part
of the `name` property. Instead, the name is just changed once on
instantiation, the stack is accessed to create the stack as expected
and then the `name` property is set back to it's original form.

PR-URL: https://github.com/nodejs/node/pull/26738
Fixes: https://github.com/nodejs/node/issues/26669
Fixes: https://github.com/nodejs/node/issues/20253
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Michaël Zasso 
Reviewed-By: Joyee Cheung

assert: align argument names

2018-09-11T21:45:07+00:00

This makes sure the documented argument names and the ones thrown
in errors is aligned with the actual argument name.

PR-URL: https://github.com/nodejs/node/pull/22760
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko 
Reviewed-By: Yuta Hiroto

test: make crashOnUnhandleRejection opt-out

2018-07-19T06:47:28+00:00

This commit removes `common.crashOnUnhandledRejection()` and adds
`common.disableCrashOnUnhandledRejection()`.

To reduce the risk of mistakes and make writing tests that involve
promises simpler, always install the unhandledRejection hook in tests
and provide a way to disable it for the rare cases where it's needed.

PR-URL: https://github.com/nodejs/node/pull/21849
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat

assert: validate the block return type

2018-04-19T22:21:33+00:00

This makes sure the returned value when calling `block` is actually
of type promise in case `assert.rejects` or `assert.doesNotReject`
is called.

PR-URL: https://github.com/nodejs/node/pull/19886
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Vse Mozhet Byt