delta/node-new.git/test/parallel/test-accessor-properties.js, branch Remove-Python-3-tests

test: simplify tests code

2019-06-09T03:02:22+00:00

PR-URL: https://github.com/nodejs/node/pull/28065
Reviewed-By: Colin Ihrig 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Richard Lau 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Rich Trott

lib: migrate process.binding to internalBinding

2019-03-06T23:21:08+00:00

Migrate various modules from using process.binding to internalBinding.

PR-URL: https://github.com/nodejs/node/pull/24952
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Anna Henningsen

src: revert removal of SecureContext `_external` getter

2018-10-12T04:04:55+00:00

This `_external` getter is essential for some libs to work:
uWebSockets as an example.

PR-URL: https://github.com/nodejs/node/pull/21711
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

dgram: make process.binding('udp_wrap') internal

2018-08-31T13:27:44+00:00

PR-URL: https://github.com/nodejs/node/pull/22475
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Michaël Zasso

tty: make process.binding('tty_wrap') internal

2018-08-29T16:28:51+00:00

PR-URL: https://github.com/nodejs/node/pull/22477
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Michaël Zasso

src: remove SecureContext `_external` getter

2018-04-26T17:57:57+00:00

This is unused inside Node core, so nothing good can
come from keeping it around.

PR-URL: https://github.com/nodejs/node/pull/20237
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Tobias Nießen

lint: move eslint to new plugin system

2018-02-20T19:13:22+00:00

PR-URL: https://github.com/nodejs/node/pull/18566
Reviewed-By: Joyee Cheung 
Reviewed-By: Roman Reiss

tls: make deprecated tls.createSecurePair() use public API

2018-01-14T13:49:41+00:00

Make the deprecated `tls.createSecurePair()` method use other public
APIs only (`TLSSocket` in particular).

Since `tls.createSecurePair()` has been runtime-deprecated only
since Node 8, it probably isn’t quite time to remove it yet,
but this patch removes almost all of the code complexity that
is retained by it.

The API, as it is documented, is retained. However, it is very likely
that some users have come to rely on parts of undocumented API
of the `SecurePair` class, especially since some of the existing
tests checked for those. Therefore, this should definitely be
considered a breaking change.

PR-URL: https://github.com/nodejs/node/pull/17882
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Minwoo Jung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Tiancheng "Timothy" Gu

test: add hasCrypto when using binding('crypto')

2017-12-29T05:09:57+00:00

Currently, when configured --without-ssl tests that use
process.binding('crypto') fail with the following error:

=== release test-accessor-properties ===
Path: parallel/test-accessor-properties
node/test/parallel/test-accessor-properties.js:16
const crypto = process.binding('crypto');
                       ^

Error: No such module: crypto
    at Object. (test-accessor-properties.js:16:24)
    at Module._compile (module.js:660:30)
    at Object.Module._extensions..js (module.js:671:10)
    at Module.load (module.js:577:32)
    at tryModuleLoad (module.js:517:12)
    at Function.Module._load (module.js:509:3)
    at Function.Module.runMain (module.js:701:10)
    at startup (bootstrap_node.js:194:16)
    at bootstrap_node.js:645:3

This commit adds a hasCrypto check.

PR-URL: https://github.com/nodejs/node/pull/17867
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater