delta/node-new.git/test/node-api/test_buffer/test-external-buffer.js, branch devsnek-patch-1 github.com: nodejs/node.git n-api: keep napi_env alive while it has finalizers 2020-01-04T06:38:36+00:00 Anna Henningsen anna@addaleax.net 2019-12-30T20:26:35+00:00 493faf606d65d4891d024163a08e6f9ee3422f5c Manage the napi_env refcount from Finalizer instances, as the finalizer may refer to the napi_env until it is deleted. Fixes: https://github.com/nodejs/node/issues/31134 Fixes: https://github.com/node-ffi-napi/node-ffi-napi/issues/48 PR-URL: https://github.com/nodejs/node/pull/31140 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> 
Manage the napi_env refcount from Finalizer instances, as the
finalizer may refer to the napi_env until it is deleted.

Fixes: https://github.com/nodejs/node/issues/31134
Fixes: https://github.com/node-ffi-napi/node-ffi-napi/issues/48
PR-URL: https://github.com/nodejs/node/pull/31140
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>