delta/node-new.git/test/js-native-api, branch cleanup-getnodeversion.py

n-api: mark version 5 N-APIs as stable

2019-09-05T16:16:54+00:00

PR-URL: https://github.com/nodejs/node/pull/29401
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson

test: refactoring test_error testing

2019-08-01T20:12:53+00:00

PR-URL: https://github.com/nodejs/node/pull/28902
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Rich Trott

n-api: refactoring napi_create_function testing

2019-08-01T06:19:41+00:00

This is a refactoring of https://github.com/nodejs/node/pull/26998
following https://github.com/nodejs/node/pull/28505.

The functions `add_last_status()` and `add_returned_status()` are now
reused, see also https://github.com/nodejs/node/pull/28848.

PR-URL: https://github.com/nodejs/node/pull/28894
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Michael Dawson 
Reviewed-By: Rich Trott

n-api: refactor a previous commit

2019-07-26T22:09:04+00:00

This is a refactoring of https://github.com/nodejs/node/issues/27628
following https://github.com/nodejs/node/pull/28505.

This change factors out functions `add_last_status()` and
`add_returned_status()` so they may be reused in the tests for passing
information about the last error status and/or a returned `napi_status`
to JavaScript.

PR-URL: https://github.com/nodejs/node/pull/28848
Reviewed-By: Anna Henningsen 
Reviewed-By: Gabriel Schulhof

n-api: add APIs for per-instance state management

2019-07-25T23:53:07+00:00

Adds `napi_set_instance_data()` and `napi_get_instance_data()`, which
allow native addons to store their data on and retrieve their data from
`napi_env`. `napi_set_instance_data()` accepts a finalizer which is
called when the `node::Environment()` is destroyed.

This entails rendering the `napi_env` local to each add-on.

Fixes: https://github.com/nodejs/abi-stable-node/issues/378
PR-URL: https://github.com/nodejs/node/pull/28682
Reviewed-By: Ben Noordhuis 
Reviewed-By: Michael Dawson

test: propagate napi_status to JS

2019-07-18T20:27:06+00:00

Re: https://github.com/nodejs/node/pull/27945#discussion_r288833979

This commit regards reporting to the JS level an actual event
that happens when using suspected improper null arguments. It is better
to report the exact reason from N-API to the JS level.

PR-URL: https://github.com/nodejs/node/pull/28505
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Michael Dawson 
Reviewed-By: Rich Trott

n-api: define ECMAScript-compliant accessors on napi_define_class

2019-06-17T10:07:08+00:00

PR-URL: https://github.com/nodejs/node/pull/27851
Fixes: https://github.com/nodejs/node/issues/26551
Fixes: https://github.com/nodejs/node-addon-api/issues/485
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Michael Dawson

n-api: define ECMAScript-compliant accessors on napi_define_properties

2019-06-17T10:06:06+00:00

PR-URL: https://github.com/nodejs/node/pull/27851
Fixes: https://github.com/nodejs/node/issues/26551
Fixes: https://github.com/nodejs/node-addon-api/issues/485
Reviewed-By: Anna Henningsen 
Reviewed-By: Gus Caplan 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Michael Dawson

src: add napi_define_class() null checks

2019-06-08T04:33:00+00:00

napi_define_class is tested by passing NULL to all parameters that are
pointers, one at a time. Moreover, two bugs were corrected. One was
utf8name and the second was the property descriptor pointer. These
pointers were assumed to be non-NULL and now we have NULL checks.

PR-URL: https://github.com/nodejs/node/pull/27945
Reviewed-By: Gabriel Schulhof

test: pass null params to napi_xxx_property()

2019-05-13T23:27:13+00:00

    For napi_set_property(), each one of the following arguments is checked:
      napi_env env,
      napi_value object,
      napi_value key,
      napi_value* value.

    For napi_has_property(), each one of the following arguments is checked:

      napi_env env,
      napi_value object,
      napi_value key,
      bool* result

    For napi_get_property, each one of the following arguments is checked:

      napi_env env,
      napi_value object,
      napi_value key,
      napi_value* result

PR-URL: https://github.com/nodejs/node/pull/27628
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Rich Trott