delta/node-new.git/test/internet, branch Remove-Python-3-tests

lib: correct error.errno to always be numeric

2019-06-17T02:18:09+00:00

Historically `error.errno` of system errors thrown by Node.js
can sometimes be the same as `err.code`, which are string
representations of the error numbers. This is useless and incorrect,
and results in an information loss for users since then they
will have to resort to something like
`process.binding('uv'[`UV_${errno}`])` to get to the numeric
error codes.

This patch corrects this behavior by always setting `error.errno`
to be negative numbers. For fabricated errors like `ENOTFOUND`,
`error.errno` is now undefined since there is no numeric equivalent
for them anyway. For c-ares errors, `error.errno` is now undefined
because the numeric representations (negated) can be in conflict
with libuv error codes - this is fine since numeric codes was
not available for c-ares errors anyway.

Users can use the public API `util.getSystemErrorName(errno)`
to retrieve string codes for these numbers.

PR-URL: https://github.com/nodejs/node/pull/28140
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: Trivikram Kamat

doc,tools: get altDocs versions from CHANGELOG.md

2019-06-01T08:17:30+00:00

Parse `CHANGELOG.md` for versions of Node.js used by the documentation
feature `View another version` so that we don't have to manually update
the list when we cut a new version or transition a release to LTS.

PR-URL: https://github.com/nodejs/node/pull/27661
Reviewed-By: Rich Trott

test: use common.PORT instead of an extraneous variable

2019-05-13T21:26:40+00:00

This test is not parallelized and so we can use the test commons PORT
variable.

Refs: https://github.com/nodejs/node/pull/27565#discussion_r281000162

PR-URL: https://github.com/nodejs/node/pull/27565
Fixes: https://github.com/nodejs/node/issues/27341
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

test: move dgram invalid host test to internet tests

2019-05-13T21:26:38+00:00

This moves a dgram test from `parallel` to `internet` because it relies
on a DNS request.
In certain cases, ISPs hijack invalid IETF-reserved invalid names which
causes a false negative failure.

Fixes: https://github.com/nodejs/node/issues/27341

PR-URL: https://github.com/nodejs/node/pull/27565
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

test: fix test-dns-idna2008.js

2019-04-15T05:40:06+00:00

The test should pass if ESERVFAIL is the result.

Refs: https://github.com/nodejs/node/issues/25870#issuecomment-471024667

PR-URL: https://github.com/nodejs/node/pull/27208
Reviewed-By: Richard Lau 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Refael Ackermann 
Reviewed-By: Luigi Pinca

test: refactor test-dgram-broadcast-multi-process

2019-03-24T02:58:04+00:00

* Add check that `signal` is not null in callback.
* Use arrow functions for callbacks, destructuring where appropriate,
  and a trailing comma in multi-line arrays

PR-URL: https://github.com/nodejs/node/pull/26846
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig

test: fix syntax error in test-dns-idna2008.js when failing

2019-03-12T15:11:38+00:00

Fixes a bug I introduced in 961322178d69325a46dbcbaea1da818fff12c45a

PR-URL: https://github.com/nodejs/node/pull/26570
Refs: https://github.com/nodejs/node/issues/25870
Refs: https://github.com/nodejs/node/pull/26473
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Rich Trott 
Reviewed-By: Ben Noordhuis

benchmark,doc,lib,test: capitalize comments

2019-03-09T23:44:40+00:00

PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Michaël Zasso

test: de-flake test-dns-idna2008.js

2019-03-09T15:13:02+00:00

* use known well-behaved DNS server
* force pass on ESERVFAIL

PR-URL: https://github.com/nodejs/node/pull/26473
Fixes: https://github.com/nodejs/node/issues/25870
Reviewed-By: Gireesh Punathil 
Reviewed-By: Rich Trott 
Reviewed-By: Joyee Cheung

benchmark,doc,lib,test: capitalize comments

2019-02-28T17:31:10+00:00

This updates a lot of comments.

PR-URL: https://github.com/nodejs/node/pull/26223
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Anto Aravinth