delta/node-new.git/test/es-module/test-esm-loader-modulemap.js, branch cleanup-getnodeversion.py

esm: phase two of new esm implementation

2019-03-27T19:52:11+00:00

This PR updates the current `--experimental-modules` implementation
based on the work of the modules team  and reflects Phase 2 of our
new modules plan.

The largest differences from the current implementation include

* `packge.type` which can be either `module` or `commonjs`
  - `type: "commonjs"`:
    - `.js` is parsed as commonjs
    - default for entry point without an extension is commonjs
  - `type: "module"`:
    - `.js` is parsed as esm
    - does not support loading JSON or Native Module by default
    - default for entry point without an extension is esm
* `--entry-type=[mode]`
  - allows you set the type on entry point.
* A new file extension `.cjs`.
  - this is specifically to support importing commonjs in the
    `module` mode.
  - this is only in the esm loader, the commonjs loader remains
    untouched, but the extension will work in the old loader if you use
    the full file path.
* `--es-module-specifier-resolution=[type]`
  - options are `explicit` (default) and `node`
  - by default our loader will not allow for optional extensions in
    the import, the path for a module must include the extension if
    there is one
  - by default our loader will not allow for importing directories that
    have an index file
  - developers can use `--es-module-specifier-resolution=node` to
    enable the commonjs specifier resolution algorithm
  - This is not a “feature” but rather an implementation for
    experimentation. It is expected to change before the flag is
    removed
* `--experimental-json-loader`
  - the only way to import json when `"type": "module"`
  - when enable all `import 'thing.json'` will go through the
    experimental loader independent of mode
  - based on https://github.com/whatwg/html/issues/4315
* You can use `package.main` to set an entry point for a module
  - the file extensions used in main will be resolved based on the
    `type` of the module

Refs: https://github.com/nodejs/modules/blob/master/doc/plan-for-new-modules-implementation.md
Refs: https://github.com/GeoffreyBooth/node-import-file-specifier-resolution-proposal
Refs: https://github.com/nodejs/modules/pull/180
Refs: https://github.com/nodejs/ecmascript-modules/pull/6
Refs: https://github.com/nodejs/ecmascript-modules/pull/12
Refs: https://github.com/nodejs/ecmascript-modules/pull/28
Refs: https://github.com/nodejs/modules/issues/255
Refs: https://github.com/whatwg/html/issues/4315
Refs: https://github.com/w3c/webcomponents/issues/770
Co-authored-by: Myles Borins 
Co-authored-by: John-David Dalton 
Co-authored-by: Evan Plaice 
Co-authored-by: Geoffrey Booth 
Co-authored-by: Michaël Zasso 

PR-URL: https://github.com/nodejs/node/pull/26745
Reviewed-By: Gus Caplan 
Reviewed-By: Guy Bedford 
Reviewed-By: Ben Coe 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Сковорода Никита Андреевич

lib: rename js source to lower snake_case

2018-03-28T06:09:16+00:00

This commit renames all JavaScript source files in lib to lower
snake_case.

PR-URL: https://github.com/nodejs/node/pull/19556
Reviewed-By: Anna Henningsen 
Reviewed-By: Trivikram Kamat 
Reviewed-By: James M Snell 
Reviewed-By: Tiancheng "Timothy" Gu

lib: always show ERR_INVALID_ARG_TYPE received part

2018-03-25T00:45:37+00:00

This makes a effort to make sure all of these errors will actually
also show the received input.
On top of that it refactors a few tests for better maintainability.
It will also change the returned type to always be a simple typeof
instead of special handling null.

PR-URL: https://github.com/nodejs/node/pull/19445
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

lib: restructure cjs and esm loaders

2018-03-15T12:50:35+00:00

Create `lib/internal/modules` and restructure the module loaders
to make the purpose of those files clearer.

Also make it clear in the code that the object exported by
`lib/internal/modules/cjs/loader.js` is `CJSModule` instead of the
ambiguous `Module`.

Before:

```
lib
├── ...
├── internal
│       ├── loaders
│       │     ├── CreateDynamicModule.js
│       │     ├── DefaultResolve.js
│       │     ├── Loader.js
│       │     ├── ModuleJob.js
│       │     ├── ModuleMap.js
│       │     └── Translators.js
│       └── module.js
└── module.js
```

After:

```
lib
├── ...
├── internal
│       ├── ...
│       └── modules
│              ├── cjs
│              │     ├── helpers.js
│              │     └── loader.js
│              └── esm
│                    ├── CreateDynamicModule.js
│                    ├── DefaultResolve.js
│                    ├── Loader.js
│                    ├── ModuleJob.js
│                    ├── ModuleMap.js
│                    └── Translators.js
└── module.js # deleted in this commit to work with git file mode
```

PR-URL: https://github.com/nodejs/node/pull/19177
Refs: https://github.com/nodejs/node/pull/19112
Reviewed-By: Gus Caplan 
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum

module: refactor loader

2018-01-15T18:42:29+00:00

PR-URL: https://github.com/nodejs/node/pull/16874
Reviewed-By: Guy Bedford 
Reviewed-By: Bradley Farias

test: increase coverage for ModuleMap

2017-11-01T20:31:24+00:00

Add test for ModuleMap set with ModuleJob but bad url.

PR-URL: https://github.com/nodejs/node/pull/16045
Reviewed-By: Stephen Belanger 
Reviewed-By: Bradley Farias 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung