delta/node-new.git/test/addons/worker-buffer-callback, branch main

src: throw DataCloneError on transfering untransferable objects

2023-05-05T11:22:42+00:00

The HTML StructuredSerializeWithTransfer algorithm defines that when
an untransferable object is in the transfer list, a DataCloneError is
thrown.
An array buffer that is already transferred is also considered as
untransferable.

PR-URL: https://github.com/nodejs/node/pull/47604
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Joyee Cheung

test: fix comment misspellings of transferred

2020-12-07T15:31:58+00:00

PR-URL: https://github.com/nodejs/node/pull/36360
Reviewed-By: Daniel Bevenius 
Reviewed-By: Zeyu Yang 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Richard Lau

src,doc,test: remove String::New default parameter

2020-07-14T13:13:34+00:00

`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: https://github.com/v8/v8/commit/e0d7f816990ada28ebe1281ca9431236ef8c6e4f

PR-URL: https://github.com/nodejs/node/pull/34248
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen 
Reviewed-By: James M Snell

test: fix out-of-bound reads from invalid sizeof usage

2020-04-30T02:56:11+00:00

`sizeof(data)` does not return the correct result here, as it measures
the size of the `data` variable, not what it points to.

PR-URL: https://github.com/nodejs/node/pull/33115
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: migrate to new V8 ArrayBuffer API

2019-12-12T15:05:44+00:00

ArrayBuffer without BackingStore will soon be deprecated.

Fixes:https://github.com/nodejs/node/issues/30529

PR-URL: https://github.com/nodejs/node/pull/30782
Fixes: https://github.com/nodejs/node/issues/30529
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

buffer: release buffers with free callbacks on env exit

2019-11-30T01:02:50+00:00

Invoke the free callback for a given `Buffer` if it was created
with one, and mark the underlying `ArrayBuffer` as detached.

This makes sure that the memory is released e.g. when addons inside
Workers create such `Buffer`s.

PR-URL: https://github.com/nodejs/node/pull/30551
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: Michael Dawson

src: mark ArrayBuffers with free callbacks as untransferable

2019-11-19T13:01:32+00:00

More precisely, make them untransferable if they were created through
*our* APIs, because those do not follow the improved free callback
mechanism that V8 uses now. All other ArrayBuffers can be transferred
between threads now, the assumption being that they were created in a
clean way that follows the V8 API on this.

This addresses a TODO comment.

Refs: https://github.com/nodejs/node/pull/30339#issuecomment-552225353

PR-URL: https://github.com/nodejs/node/pull/30475
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: David Carlier