delta/node-new.git/test/addons/non-node-context/binding.cc, branch Remove-Python-3-tests github.com: nodejs/node.git buffer: throw exception when creating from non-Node.js Context 2018-11-04T06:31:03+00:00 Anna Henningsen anna@addaleax.net 2018-10-28T14:59:20+00:00 9c7d19104d1f03f70658a6834a7d0baac7d38724 Throw an exception instead of crashing when attempting to create `Buffer` objects from a Context that is not associated with a Node.js `Environment`. Possible alternatives for the future might be just returning a plain `Uint8Array`, or working on providing `Buffer` for all `Context`s. PR-URL: https://github.com/nodejs/node/pull/23938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> 
Throw an exception instead of crashing when attempting to create
`Buffer` objects from a Context that is not associated with
a Node.js `Environment`.

Possible alternatives for the future might be just returning
a plain `Uint8Array`, or working on providing `Buffer` for all
`Context`s.

PR-URL: https://github.com/nodejs/node/pull/23938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
test: verify `performance.timerify()` works w/ non-Node Contexts 2018-10-25T17:49:46+00:00 Anna Henningsen anna@addaleax.net 2018-10-20T11:50:10+00:00 a3cad3e2ff95eb7474b4baefafc969211657a896 PR-URL: https://github.com/nodejs/node/pull/23784 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> 
PR-URL: https://github.com/nodejs/node/pull/23784
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>