delta/node-new.git/test/addons/node-module-version, branch Remove-Python-3-tests

test, tools: suppress addon function cast warnings

2019-02-01T13:08:20+00:00

Currently, there are a number of compiler warnings generated when
building the addons on Linux, for example:

make[1]: Entering directory '/node/test/addons/zlib-binding/build'
  CXX(target) Release/obj.target/binding/binding.o
  SOLINK_MODULE(target) Release/obj.target/binding.node
  COPY Release/binding.node
make[1]: Leaving directory '/node/test/addons/zlib-binding/build'
In file included from ../binding.cc:1:
/node/src/node.h:515:51: warning:
cast between incompatible function types from
'void (*)(v8::Local,
          v8::Local,
          v8::Local)' to
'node::addon_context_register_func' {aka
'void (*)(v8::Local,
          v8::Local,
          v8::Local,
          void*)'} [-Wcast-function-type]
(node::addon_context_register_func) (regfunc), \
					   ^
/node/src/node.h:533:3:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X'
   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../binding.cc:58:1:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE'
 NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
 ^~~~~~~~~~~~~~~~~~~~~~~~~

This commit adds the flag -Wno-cast-function-type to suppress these
warnings. With this change the warnings are not displayed anymore and
the output matches that of osx when running
'make -j8 test/addons/.buildstamp'.

PR-URL: https://github.com/nodejs/node/pull/25663
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Richard Lau

n-api: use module name macro

2017-10-15T23:00:29+00:00

Update tests to use module name macro

PR-URL: https://github.com/nodejs/node/pull/16185
Reviewed-By: Gabriel Schulhof 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

tools: add unescaped regexp dot rule to linter

2017-03-29T08:53:28+00:00

PR-URL: https://github.com/nodejs/node/pull/11834
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Teddy Katz 
Reviewed-By: Franziska Hinkelmann

test: improve module version mismatch error check

2017-01-09T17:05:02+00:00

Refs: https://github.com/nodejs/node/pull/10606
PR-URL: https://github.com/nodejs/node/pull/10636
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

test: enable node-module-version/test.js with debug

2016-10-17T07:53:28+00:00

Commit fdca79fbc0a797206fa690d51b8844ed4fd596d6 ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.

PR-URL: https://github.com/nodejs/node/pull/9093
Reviewed-By: Santiago Gimeno 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

src: update module version mismatch error message

2016-10-10T15:56:31+00:00

Fixes: https://github.com/nodejs/node/issues/8379
PR-URL: https://github.com/nodejs/node/pull/8391
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum