delta/node-new.git/test/addons/hello-world, branch Remove-Python-3-tests

test: make exported method static

2019-08-16T05:58:40+00:00

The exported method can be static as it will never be called directly.

PR-URL: https://github.com/nodejs/node/pull/29102
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott

test, tools: suppress addon function cast warnings

2019-02-01T13:08:20+00:00

Currently, there are a number of compiler warnings generated when
building the addons on Linux, for example:

make[1]: Entering directory '/node/test/addons/zlib-binding/build'
  CXX(target) Release/obj.target/binding/binding.o
  SOLINK_MODULE(target) Release/obj.target/binding.node
  COPY Release/binding.node
make[1]: Leaving directory '/node/test/addons/zlib-binding/build'
In file included from ../binding.cc:1:
/node/src/node.h:515:51: warning:
cast between incompatible function types from
'void (*)(v8::Local,
          v8::Local,
          v8::Local)' to
'node::addon_context_register_func' {aka
'void (*)(v8::Local,
          v8::Local,
          v8::Local,
          void*)'} [-Wcast-function-type]
(node::addon_context_register_func) (regfunc), \
					   ^
/node/src/node.h:533:3:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE_X'
   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../binding.cc:58:1:
note: in expansion of macro 'NODE_MODULE_CONTEXT_AWARE'
 NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME, Initialize)
 ^~~~~~~~~~~~~~~~~~~~~~~~~

This commit adds the flag -Wno-cast-function-type to suppress these
warnings. With this change the warnings are not displayed anymore and
the output matches that of osx when running
'make -j8 test/addons/.buildstamp'.

PR-URL: https://github.com/nodejs/node/pull/25663
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Richard Lau

worker: remove `--experimental-worker` flag

2019-01-08T23:31:33+00:00

Having an experimental feature behind a flag makes change
if we are expecting significant breaking changes to its API.

Since the Worker API has been essentially stable since
its initial introduction, and no noticeable doubt about
possibly not keeping the feature around has been voiced,
removing the flag and thereby reducing the barrier to experimentation,
and consequently receiving feedback on the implementation,
seems like a good idea.

PR-URL: https://github.com/nodejs/node/pull/25361
Reviewed-By: Rich Trott 
Reviewed-By: Yuta Hiroto 
Reviewed-By: Shingo Inoue 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Tobias Nießen 
Reviewed-By: Masashi Hirano 
Reviewed-By: Weijia Wang 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Michael Dawson

test,doc: add tests and docs for addon unloading

2018-12-20T02:34:28+00:00

Originally from portions of https://github.com/nodejs/node/pull/23319/.

PR-URL: https://github.com/nodejs/node/pull/24861
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung

test: fix NewFromUtf8 compiler warning

2018-11-10T05:26:31+00:00

Currently there are a number of compiler warnings like the following:

../binding.cc:6:41:
warning: 'NewFromUtf8' is deprecated:
Use maybe version [-Wdeprecated-declarations]
  args.GetReturnValue().Set(v8::String::NewFromUtf8(isolate, "world"));
                                        ^
/node/deps/v8/include/v8.h:2883:10:
note: 'NewFromUtf8' has been explicitly marked deprecated here
  static V8_DEPRECATE_SOON(
         ^
/node/deps/v8/include/v8config.h:341:29:
note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^

This commit updates the code to use the maybe versions.

PR-URL: https://github.com/nodejs/node/pull/24216
Reviewed-By: Michaël Zasso 
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig

src: add context-aware init macro and doc

2018-07-03T22:34:50+00:00

Introduces macros `NODE_MODULE_INITIALIZER` which expands to the name
of the special symbol that process.dlopen() will look for to initialize
an addon, and `NODE_MODULE_INIT()` which creates the boilerplate for
a context-aware module which can be loaded multiple times via the
special symbol mechanism.

Additionally, provides an example of using the new macro to construct
an addon which stores per-addon-instance data in a heap-allocated
structure that gets passed to each binding, rather than in a collection
of global static variables.

Re: https://github.com/nodejs/node/issues/21291#issuecomment-396729727
PR-URL: https://github.com/nodejs/node/pull/21318
Reviewed-By: Matteo Collina 
Reviewed-By: James M Snell 
Reviewed-By: Ujjwal Sharma

src: cover extra load-via-special-symbol scenario

2018-04-23T12:59:03+00:00

We need to look for a special symbol even if the module self-registers
when the module self-registers with the wrong version.

PR-URL: https://github.com/nodejs/node/pull/20186
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung

test: verify multiple init via well-known symbol

2018-04-09T01:21:07+00:00

Re-`require()` the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.

PR-URL: https://github.com/nodejs/node/pull/19875
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater

src: make process.dlopen() load well-known symbol

2018-03-01T12:45:57+00:00

Look for symbol `node_register_module_v${NODE_MODULE_VERSION}` if the
add-on didn't self-register.  This can be used to create add-ons that
support multiple Node.js versions from a single shared object.

PR-URL: https://github.com/nodejs/node/pull/18934
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Matheus Marchini 
Reviewed-By: Tobias Nießen

test,doc: make module name match gyp target name

2017-09-09T21:15:49+00:00

Currently the nm_modname does not match the file name of the resulting
module. In fact, the nm_modname is pretty arbitrary. This seeks to
introduce some consistency into the nm_modname property by having the
name of the module appear in exactly one place: the "target_name"
property of the gyp target that builds the module.

PR-URL: https://github.com/nodejs/node/pull/15209
Reviewed-By: Refael Ackermann 
Reviewed-By: Colin Ihrig