delta/node-new.git/src, branch sam-github-tsc

vm: add run-after-evaluate microtask mode

2020-06-26T18:41:33+00:00

This allows timeouts to apply to e.g. `Promise`s and `async function`s
from code running inside of `vm.Context`s, by giving the Context its
own microtasks queue.

Fixes: https://github.com/nodejs/node/issues/3020

PR-URL: https://github.com/nodejs/node/pull/34023
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko

src: add errorProperties on process.report

2020-06-26T17:06:22+00:00

PR-URL: https://github.com/nodejs/node/pull/28426
Reviewed-By: Gireesh Punathil 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

lib,src: remove cpu profiler idle notifier

2020-06-25T18:52:53+00:00

I added it in commit 57231d5286 ("src: notify V8 profiler when we're
idle") from October 2013 as a stop-gap measure to measure CPU time
rather than wall clock time, otherwise processes that spend a lot
of time sleeping in system calls give a false impression of being
very busy.

That fix is not without drawbacks because the idle flag is set before
libuv makes I/O callbacks and cleared again after. I/O callbacks can
result into calls into JS code and executing JS code is as non-idle
as you can get.

In commit 96ffcb9a21 ("src: reduce cpu profiler overhead") from January
2015, I made Node.js block off the SIGPROF signal that V8's CPU profiler
uses before Node.js goes to sleep. The goal of that commit is to reduce
the overhead from EINTR system call wakeups but it also has the pleasant
side effect of fixing what the idle notifier tried to fix.

This commit removes the idle notifier and turns the JS process object
methods into no-ops.

Fixes: https://github.com/nodejs/node/issues/19009
Refs: https://github.com/nodejs/node/pull/33138

PR-URL: https://github.com/nodejs/node/pull/34010
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: tolerate EPERM returned from tcsetattr

2020-06-25T17:56:34+00:00

macOS app sandbox makes tcsetattr return EPERM. The CHECK_EQ(0, err)
here would fail when a sandboxed Node.js process is exiting. This commit
fixes this issue.

* test: add test for running in macOS app sandbox

Bare-bone command-line executables cannot run directly in the app sandbox.
To test that Node.js is able to run in the sandbox (and to test the fix in
317621b4a12562eb75055a67bb2c5556f53fe017), this commit creates a typical
Cocoa app bundle, puts the node executable in it and calles Apple's codesign
command to enable sandbox.

* test: use process.execPath to get path of testing node

PR-URL: https://github.com/nodejs/node/pull/33944
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: clang_format base_object

2020-06-25T17:50:24+00:00

PR-URL: https://github.com/nodejs/node/pull/33680
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell

src: fix ParseEncoding

2020-06-25T16:14:23+00:00

"utf-16LE" was parsed "UNKNOWN", this fixes to "UCS2"
"utf-buffer" was parsed "BUFFER", this fixes to "UNKNOWN"
"utf-16leNOT" was parsed "UCS2", this fixes to "UNKNOWN"

PR-URL: https://github.com/nodejs/node/pull/33957
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

worker: add public method for marking objects as untransferable

2020-06-25T15:33:29+00:00

We currently mark a number of `ArrayBuffer`s as not transferable,
including the `Buffer` pool and ones with finalizers provided
by C++ addons.

There is no good reason to assume that userland code might not
encounter similar problems, for example when doing `ArrayBuffer`
pooling similar to ours. Therefore, provide an API that lets
userland code also mark objects as not transferable.

PR-URL: https://github.com/nodejs/node/pull/33979
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: remove unnecessary calculation in base64.h

2020-06-25T14:44:04+00:00

PR-URL: https://github.com/nodejs/node/pull/33839
Reviewed-By: Anna Henningsen 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

src: use ToLocal in node_os.cc

2020-06-25T01:00:51+00:00

PR-URL: https://github.com/nodejs/node/pull/33939
Reviewed-By: Richard Lau 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

worker: rename error code to be more accurate

2020-06-25T00:56:55+00:00

Rename `ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST`
to `ERR_MISSING_TRANSFERABLE_IN_TRANSFER_LIST` in order to be more
accurate.

PR-URL: https://github.com/nodejs/node/pull/33872
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: James M Snell 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen