delta/node-new.git/src, branch pull-request-doc-updates

report: include information about event loop itself

2019-02-06T14:36:24+00:00

PR-URL: https://github.com/nodejs/node/pull/25906
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell

src: remove redundant method in node_worker.h

2019-02-06T04:55:43+00:00

Signed-off-by: gengjiawen 

PR-URL: https://github.com/nodejs/node/pull/25849
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: delete unreachable code in node_perf.h

2019-02-06T04:49:27+00:00

Signed-off-by: gengjiawen 

PR-URL: https://github.com/nodejs/node/pull/25850
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

src: move process.reallyExit impl into node_process_methods.cc

2019-02-06T04:36:35+00:00

Because the part that is shared by `process.reallyExit` and the
Node.js teardown is `WaitForInspectorDisconnect()`, move that
into node_internals.h instead, and move the C++ binding code
into `node_process_methods.cc` since that's the only place
it's needed.

PR-URL: https://github.com/nodejs/node/pull/25860
Reviewed-By: Anna Henningsen 
Reviewed-By: Minwoo Jung 
Reviewed-By: Jeremiah Senkpiel

src: fix data type in node_crypto.cc

2019-02-06T04:26:50+00:00

Signed-off-by: gengjiawen 

PR-URL: https://github.com/nodejs/node/pull/25889
Reviewed-By: Anna Henningsen 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

tls: in-line comments and other cleanups

2019-02-05T23:17:53+00:00

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen

src: const_cast is necessary for 1.1.1, not 0.9.7

2019-02-05T23:16:58+00:00

The const_cast used to be necessary for SSL_get_app_data() in OpenSSL
0.9.7, but node doesn't compile against OpenSSL versions that old.
However, now it's needed for the recently introduced
SSL_renegotiate_pending(), which is not const-correct as of 1.1.1a.

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen

src: refactor SSLError case statement

2019-02-05T23:16:45+00:00

- Don't use both break and return simultaneously.
- Use case:/UNREACHABLE() to enforce that all cases are handled, instead
  of CHECK().

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen

src: organize TLSWrap declarations by parent

2019-02-05T23:16:34+00:00

Make it clear which of the multiple interfaces a TLSWrap method is
implementing by grouping and commenting the related methods.

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen

src: remove unused TLWrap::EnableTrace()

2019-02-05T23:16:28+00:00

Declaration is unused, it was added by mistake in 46c5c3388d2.

PR-URL: https://github.com/nodejs/node/pull/25861
Reviewed-By: Fedor Indutny 
Reviewed-By: Anna Henningsen