<feed xmlns='http://www.w3.org/2005/Atom'>
<title>delta/node-new.git/src, branch main</title>
<subtitle>github.com: nodejs/node.git
</subtitle>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/'/>
<entry>
<title>deps: update undici to 5.22.1</title>
<updated>2023-05-16T16:36:34+00:00</updated>
<author>
<name>Node.js GitHub Bot</name>
<email>github-bot@iojs.org</email>
</author>
<published>2023-05-16T16:36:34+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=7a57d1fb942467a4aa255ee11e09a4ca0003ce85'/>
<id>7a57d1fb942467a4aa255ee11e09a4ca0003ce85</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/47994
Reviewed-By: Matthew Aitken &lt;maitken033380023@gmail.com&gt;
Reviewed-By: Moshe Atlow &lt;moshe@atlow.co.il&gt;
Reviewed-By: Mohammed Keyvanzadeh &lt;mohammadkeyvanzade94@gmail.com&gt;
Reviewed-By: Mestery &lt;mestery@protonmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/47994
Reviewed-By: Matthew Aitken &lt;maitken033380023@gmail.com&gt;
Reviewed-By: Moshe Atlow &lt;moshe@atlow.co.il&gt;
Reviewed-By: Mohammed Keyvanzadeh &lt;mohammadkeyvanzade94@gmail.com&gt;
Reviewed-By: Mestery &lt;mestery@protonmail.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>doc: fix typo in binding functions</title>
<updated>2023-05-16T14:26:17+00:00</updated>
<author>
<name>Deokjin Kim</name>
<email>deokjin81.kim@gmail.com</email>
</author>
<published>2023-05-16T14:26:17+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=d2c4518ce65e48c1f32f435c1f06519723873f0c'/>
<id>d2c4518ce65e48c1f32f435c1f06519723873f0c</id>
<content type='text'>
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: https://github.com/nodejs/node/pull/48003
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Daeyeon Jeong &lt;daeyeon.dev@gmail.com&gt;
Reviewed-By: Harshitha K P &lt;harshitha014@gmail.com&gt;
Reviewed-By: Luigi Pinca &lt;luigipinca@gmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
According to usage(node::util::RegisterExternalReferences) of
below line, namespace has to be `util`(not `utils`).

PR-URL: https://github.com/nodejs/node/pull/48003
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Daeyeon Jeong &lt;daeyeon.dev@gmail.com&gt;
Reviewed-By: Harshitha K P &lt;harshitha014@gmail.com&gt;
Reviewed-By: Luigi Pinca &lt;luigipinca@gmail.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>permission: remove unused function declaration</title>
<updated>2023-05-15T14:18:07+00:00</updated>
<author>
<name>Deokjin Kim</name>
<email>deokjin81.kim@gmail.com</email>
</author>
<published>2023-05-15T14:18:07+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=8cbc307c44865703ae6976de94ad3470d5f71518'/>
<id>8cbc307c44865703ae6976de94ad3470d5f71518</id>
<content type='text'>
RestrictAccess() is declared, but it's not used.

PR-URL: https://github.com/nodejs/node/pull/47957
Reviewed-By: Tobias Nießen &lt;tniessen@tnie.de&gt;
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
Reviewed-By: Yagiz Nizipli &lt;yagiz@nizipli.com&gt;
Reviewed-By: Rafael Gonzaga &lt;rafael.nunu@hotmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Luigi Pinca &lt;luigipinca@gmail.com&gt;
Reviewed-By: Khaidi Chu &lt;i@2333.moe&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
RestrictAccess() is declared, but it's not used.

PR-URL: https://github.com/nodejs/node/pull/47957
Reviewed-By: Tobias Nießen &lt;tniessen@tnie.de&gt;
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
Reviewed-By: Yagiz Nizipli &lt;yagiz@nizipli.com&gt;
Reviewed-By: Rafael Gonzaga &lt;rafael.nunu@hotmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Luigi Pinca &lt;luigipinca@gmail.com&gt;
Reviewed-By: Khaidi Chu &lt;i@2333.moe&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>src: deduplicate X509Certificate::Fingerprint*</title>
<updated>2023-05-15T12:49:00+00:00</updated>
<author>
<name>Tobias Nießen</name>
<email>tniessen@tnie.de</email>
</author>
<published>2023-05-15T12:49:00+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=93a19961a6a824d4cd42553967ccac3124c38727'/>
<id>93a19961a6a824d4cd42553967ccac3124c38727</id>
<content type='text'>
All three functions do the same, except using different cryptographic
hash functions. Move the common logic into a new template and use it
directly.

PR-URL: https://github.com/nodejs/node/pull/47978
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
Reviewed-By: Filip Skokan &lt;panva.ip@gmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
All three functions do the same, except using different cryptographic
hash functions. Move the common logic into a new template and use it
directly.

PR-URL: https://github.com/nodejs/node/pull/47978
Reviewed-By: Ben Noordhuis &lt;info@bnoordhuis.nl&gt;
Reviewed-By: Filip Skokan &lt;panva.ip@gmail.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>vm: fix crash when setting __proto__ on context's globalThis</title>
<updated>2023-05-15T09:24:15+00:00</updated>
<author>
<name>Feng Yu</name>
<email>F3n67u@outlook.com</email>
</author>
<published>2023-05-15T09:24:15+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=6bbf2a57fcf33266c5859497f8cc32e1389a358a'/>
<id>6bbf2a57fcf33266c5859497f8cc32e1389a358a</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/47939
Reviewed-By: Zeyu "Alex" Yang &lt;himself65@outlook.com&gt;
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Anna Henningsen &lt;anna@addaleax.net&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/47939
Reviewed-By: Zeyu "Alex" Yang &lt;himself65@outlook.com&gt;
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Anna Henningsen &lt;anna@addaleax.net&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>src: stop copying code cache, part 2</title>
<updated>2023-05-15T04:37:24+00:00</updated>
<author>
<name>Keyhan Vakil</name>
<email>kvakil@sylph.kvakil.me</email>
</author>
<published>2023-05-15T04:37:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=3ef17b635653d0f862a093a50d611b18577348c2'/>
<id>3ef17b635653d0f862a093a50d611b18577348c2</id>
<content type='text'>
This removes more copies of the code cache data.

First: for the builtin snapshot, we were copying the code cache to
create a `std::vector&lt;uint8_t&gt;`. This was slowing down static
intialization. Change it to use a good old `uint8_t*` and `size_t`
rather than a vector. For the case of embedder provided snapshots, we
also add an `owning_ptr` so that we can properly cleanup owned values
created from the snapshot.

Second: whenever the code cache was hit, we would remove the bytecode
from the code cache, and then reserialize it from the compiled function.
This was pretty slow. Change the code so that we can reuse the same code
cache multiple times. If the code cache is rejected (say, because the
user added V8 options), then we need to generate the bytecode, in which
case we again use `owning_ptr` to ensure that the underlying code cache
is freed.

Combined, these changes improve the misc/startup.js benchmarks
significantly (p &lt; 0.001):

* process,benchmark/fixtures/require-builtins: 22.15%
* process,test/fixtures/semicolon: 8.55%
* worker,benchmark/fixtures/require-builtins: 26.52%
* worker,test/fixtures/semicolon: 21.52%

PR-URL: https://github.com/nodejs/node/pull/47958
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
Reviewed-By: Minwoo Jung &lt;nodecorelab@gmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This removes more copies of the code cache data.

First: for the builtin snapshot, we were copying the code cache to
create a `std::vector&lt;uint8_t&gt;`. This was slowing down static
intialization. Change it to use a good old `uint8_t*` and `size_t`
rather than a vector. For the case of embedder provided snapshots, we
also add an `owning_ptr` so that we can properly cleanup owned values
created from the snapshot.

Second: whenever the code cache was hit, we would remove the bytecode
from the code cache, and then reserialize it from the compiled function.
This was pretty slow. Change the code so that we can reuse the same code
cache multiple times. If the code cache is rejected (say, because the
user added V8 options), then we need to generate the bytecode, in which
case we again use `owning_ptr` to ensure that the underlying code cache
is freed.

Combined, these changes improve the misc/startup.js benchmarks
significantly (p &lt; 0.001):

* process,benchmark/fixtures/require-builtins: 22.15%
* process,test/fixtures/semicolon: 8.55%
* worker,benchmark/fixtures/require-builtins: 26.52%
* worker,test/fixtures/semicolon: 21.52%

PR-URL: https://github.com/nodejs/node/pull/47958
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
Reviewed-By: Minwoo Jung &lt;nodecorelab@gmail.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>src: add cjs_module_lexer_version base64_version</title>
<updated>2023-05-14T12:16:47+00:00</updated>
<author>
<name>Jithil P Ponnan</name>
<email>MrJithil@users.noreply.github.com</email>
</author>
<published>2023-05-14T12:16:47+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=abb1c45af774ae3caaa449ddcbfe44143a98e9c7'/>
<id>abb1c45af774ae3caaa449ddcbfe44143a98e9c7</id>
<content type='text'>
src: add cjs_module_lexer_version base64_version
PR-URL: https://github.com/nodejs/node/pull/45629
Refs: https://github.com/nodejs/node/issues/45260
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Minwoo Jung &lt;nodecorelab@gmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
src: add cjs_module_lexer_version base64_version
PR-URL: https://github.com/nodejs/node/pull/45629
Refs: https://github.com/nodejs/node/issues/45260
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Minwoo Jung &lt;nodecorelab@gmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Antoine du Hamel &lt;duhamelantoine1995@gmail.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>src: move BlobSerializerDeserializer to a separate header file</title>
<updated>2023-05-11T12:49:24+00:00</updated>
<author>
<name>Darshan Sen</name>
<email>raisinten@gmail.com</email>
</author>
<published>2023-05-09T07:45:20+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=78fe139b33fb974efdbcbb032c0ca985ea63ef68'/>
<id>78fe139b33fb974efdbcbb032c0ca985ea63ef68</id>
<content type='text'>
This should make it possible to reuse the BlobSerializer and the
BlobDeserializer classes in SEAs to generate and parse the injected
blob.

This change also resolves this TODO:
https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187

Refs: https://github.com/nodejs/node/pull/47458
Signed-off-by: Darshan Sen &lt;raisinten@gmail.com&gt;
PR-URL: https://github.com/nodejs/node/pull/47933
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This should make it possible to reuse the BlobSerializer and the
BlobDeserializer classes in SEAs to generate and parse the injected
blob.

This change also resolves this TODO:
https://github.com/nodejs/node/blob/4f69aae6a04a460f267005dcf6551959064b3238/src/node_snapshotable.cc#L187

Refs: https://github.com/nodejs/node/pull/47458
Signed-off-by: Darshan Sen &lt;raisinten@gmail.com&gt;
PR-URL: https://github.com/nodejs/node/pull/47933
Reviewed-By: Joyee Cheung &lt;joyeec9h3@gmail.com&gt;
Reviewed-By: Colin Ihrig &lt;cjihrig@gmail.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>dns: call `ada::idna::to_ascii` directly from c++</title>
<updated>2023-05-10T16:04:35+00:00</updated>
<author>
<name>Yagiz Nizipli</name>
<email>yagiz@nizipli.com</email>
</author>
<published>2023-05-10T16:04:35+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=8b5cd3248dbf00de3e23644739e5c89c1a6a9ff4'/>
<id>8b5cd3248dbf00de3e23644739e5c89c1a6a9ff4</id>
<content type='text'>
PR-URL: https://github.com/nodejs/node/pull/47920
Fixes: https://github.com/nodejs/performance/issues/77
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Matteo Collina &lt;matteo.collina@gmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PR-URL: https://github.com/nodejs/node/pull/47920
Fixes: https://github.com/nodejs/performance/issues/77
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Matteo Collina &lt;matteo.collina@gmail.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>src: rename SKIP_CHECK_SIZE to SKIP_CHECK_STRLEN</title>
<updated>2023-05-10T13:20:04+00:00</updated>
<author>
<name>Tobias Nießen</name>
<email>tniessen@tnie.de</email>
</author>
<published>2023-05-10T13:20:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.baserock.org/cgit/delta/node-new.git/commit/?id=19afcba9d46911d8ea46ec0500a74d177ecb48ca'/>
<id>19afcba9d46911d8ea46ec0500a74d177ecb48ca</id>
<content type='text'>
SKIP_CHECK_VALUE is a string literal, so its size is the length of the
string in chars plus one. The buffer buf is also always null-terminated,
so its size should match the size of SKIP_CHECK_VALUE, which is _not_
SKIP_CHECK_SIZE.

Rename SKIP_CHECK_SIZE to be consistent with C/C++ terminology.

PR-URL: https://github.com/nodejs/node/pull/47845
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Shelley Vohr &lt;shelley.vohr@gmail.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
SKIP_CHECK_VALUE is a string literal, so its size is the length of the
string in chars plus one. The buffer buf is also always null-terminated,
so its size should match the size of SKIP_CHECK_VALUE, which is _not_
SKIP_CHECK_SIZE.

Rename SKIP_CHECK_SIZE to be consistent with C/C++ terminology.

PR-URL: https://github.com/nodejs/node/pull/47845
Reviewed-By: James M Snell &lt;jasnell@gmail.com&gt;
Reviewed-By: Darshan Sen &lt;raisinten@gmail.com&gt;
Reviewed-By: Shelley Vohr &lt;shelley.vohr@gmail.com&gt;</pre>
</div>
</content>
</entry>
</feed>
