delta/node-new.git/src, branch crypto_set_integer_macro

crypto: add SET_INTEGER_CONSTANT macro

2018-10-17T03:38:08+00:00

This commit introduces a SET_INTEGER_CONSTANT macro to reduce some code
duplication in SecureContext::Initialize.

src: remove OCB support ifdef OPENSSL_NO_OCB

2018-10-16T21:26:47+00:00

Electron uses BoringSSL which does not support OCB . It is also
possible to build OpenSSL without support for OCB for Node.js.
This commit disables OCB if OPENSSL_NO_OCB is defined.

PR-URL: https://github.com/nodejs/node/pull/23635
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen

src: add deprecation warning to errname()

2018-10-16T11:46:30+00:00

PR-URL: https://github.com/nodejs/node/pull/23597
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Сковорода Никита Андреевич 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani

zlib: refactor zlib internals

2018-10-16T03:26:20+00:00

Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: https://github.com/nodejs/node/pull/23360
Reviewed-By: James M Snell 
Reviewed-By: Daniel Bevenius

async_hooks: remove promise object from resource

2018-10-15T18:40:51+00:00

While it doesn't make any difference now. In the future PromiseHooks
could be refactored to provide an asyncId instead of the promise object.
That would make escape analysis on promises possible.

Escape analysis on promises could lead to a more efficient destroy hook,
if provide by PromiseHooks as well. But at the very least would allow
the destroy hook to be emitted earlier. The destroy hook not being
emitted on promises frequent enough is a known and reported issue.
See https://github.com/nodejs/node/issues/14446 and
https://github.com/Jeff-Lewis/cls-hooked/issues/11.

While all this is speculation for now, it all depends on the promise
object not being a part of the PromiseWrap resource object.

Ref: https://github.com/nodejs/node/issues/14446
Ref: https://github.com/nodejs/diagnostics/issues/188

PR-URL: https://github.com/nodejs/node/pull/23443
Refs: https://github.com/nodejs/node/issues/14446
Refs: https://github.com/nodejs/diagnostics/issues/188
Reviewed-By: Benedikt Meurer 
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina 
Reviewed-By: George Adams

src: change macro to fn

2018-10-15T13:38:36+00:00

Change base64_encoded_size and unbase64 to inline functions. The
base64_encoded_size is a constexpr to be used in function declarations.

PR-URL: https://github.com/nodejs/node/pull/23603
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani

src: add default initializer in tls_wrap

2018-10-15T13:34:45+00:00

PR-URL: https://github.com/nodejs/node/pull/23567
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

buffer: move process.binding('buffer') to internalBinding

2018-10-15T11:01:20+00:00

PR-URL: https://github.com/nodejs/node/pull/22370
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: Matteo Collina 
Reviewed-By: Anna Henningsen

src: use MallocedBuffer abstraction for buffers

2018-10-15T10:03:08+00:00

Drop `Free` and `std::unique_ptr` in favor of Node's `MallocedBuffer`
for `char[]` buffer memory mangement.

PR-URL: https://github.com/nodejs/node/pull/23543
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Franziska Hinkelmann

src: use default initializers over settings fields on the constructor

2018-10-15T10:03:08+00:00

PR-URL: https://github.com/nodejs/node/pull/23532
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater