delta/node-new.git/src, branch cleanup-getnodeversion.py

src: perform check before running in runMicrotasks()

2019-09-23T02:09:48+00:00

This is a continuation of https://github.com/nodejs/node/pull/29434,
rewriting the last remaining call to RunMicrotasks.

PR-URL: https://github.com/nodejs/node/pull/29581
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan 
Reviewed-By: Shelley Vohr 
Reviewed-By: Minwoo Jung 
Reviewed-By: David Carlier 
Reviewed-By: Ruben Bridgewater

src: discard remaining foreground tasks on platform shutdown

2019-09-23T00:00:43+00:00

While V8 itself should not have any remaining tasks on the queue
during platform shutdown, our inspector implementation may do so.
Thus, the checks verifying that no tasks are queued at that point
make some of the inspector tasks flaky.
Remove the checks and replace them by explicitly destroying all
tasks that are left.

Refs: https://github.com/nodejs/node/pull/25653
Refs: https://github.com/nodejs/node/pull/28870#issuecomment-531908090

PR-URL: https://github.com/nodejs/node/pull/29587
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Minwoo Jung

crypto: use BoringSSL-compatible flag getter

2019-09-22T20:05:12+00:00

PR-URL: https://github.com/nodejs/node/pull/29604
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott 
Reviewed-By: David Carlier 
Reviewed-By: Tobias Nießen

process: initial SourceMap support via NODE_V8_COVERAGE

2019-09-21T22:39:41+00:00

PR-URL: https://github.com/nodejs/node/pull/28960
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Matteo Collina 
Reviewed-By: David Carlier

src: fix closing weak `HandleWrap`s on GC

2019-09-21T20:53:25+00:00

In 0af62aae07ccbb3783030367ffe4, this was overlooked, with it
possibly leading to hard crashes.

Refs: https://github.com/nodejs/node/pull/29317

PR-URL: https://github.com/nodejs/node/pull/29640
Reviewed-By: Ben Coe 
Reviewed-By: Rich Trott

http: remove legacy parser

2019-09-20T18:18:35+00:00

Remove the legacy `http_parser` implementation as a dependency
and all code that uses it in favor of llhttp, given that the latter
has been the default for all of Node 12 with no outstanding issues.

PR-URL: https://github.com/nodejs/node/pull/29589
Reviewed-By: Colin Ihrig 
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell 
Reviewed-By: Jiawen Geng 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Minwoo Jung 
Reviewed-By: Trivikram Kamat

module: error for CJS .js load within type: module

2019-09-19T22:24:50+00:00

PR-URL: https://github.com/nodejs/node/pull/29492
Reviewed-By: Jan Krems

src: use libuv to get env vars

2019-09-18T21:24:46+00:00

This allows us to remove OS-dependent code.

                                                           confidence improvement accuracy (*)    (**)   (***)
     process/bench-env.js operation='delete' n=1000000                    3.57 %      ±10.86% ±14.46% ±18.85%
     process/bench-env.js operation='enumerate' n=1000000        ***    -14.06 %       ±7.46%  ±9.94% ±12.96%
     process/bench-env.js operation='get' n=1000000                      -7.97 %      ±11.80% ±15.70% ±20.45%
     process/bench-env.js operation='query' n=1000000                    -1.32 %       ±8.38% ±11.17% ±14.58%
     process/bench-env.js operation='set' n=1000000                      -0.98 %       ±9.63% ±12.81% ±16.68%

The drop in enumeration performance is likely due to the large
number of extra allocations that libuv performs. However, enumerating
process.env should generally not be a hot path in most applications.

PR-URL: https://github.com/nodejs/node/pull/29188
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: re-delete Atomics.wake

2019-09-18T21:09:20+00:00

PR-URL: https://github.com/nodejs/node/pull/29586
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier

module: reintroduce package exports dot main

2019-09-18T01:54:44+00:00

This reintroduces the dot main in exports as discussed in the previous
Node.js modules meeting.

The implementation includes both CommonJS and ES module resolution with
the associated documentation and resolver specification changes.

In addition to the dot main, "exports" as a string or direct fallback
array is supported as well.

Co-Authored-By: Geoffrey Booth 
PR-URL: https://github.com/nodejs/node/pull/29494
Reviewed-By: Jan Krems 
Reviewed-By: Myles Borins