delta/node-new.git/src/util.h, branch try_Python3_on_macOS

fs: allow int64 offset in fs.read/readSync/fd.read

2019-08-17T05:09:27+00:00

Since v10.10.0, 'buf' can be any DataView, meaning the largest
byteLength can be Float64Array.BYTES_PER_ELEMENT * kMaxLength =
17,179,869,176.

'offset' can now be up to 2**53 - 1. This makes it possible to tile
reads into a large buffer.

Breaking: now throws if read offset is not a safe int, is null or
is undefined.

Fixes https://github.com/nodejs/node/issues/26563

PR-URL: https://github.com/nodejs/node/pull/26572
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: use ArrayBufferViewContents more frequently

2019-05-29T17:28:38+00:00

Using `ArrayBufferViewContents` over
`Buffer::Data()`/`Buffer::Length()` or `SPREAD_BUFFER_ARG` has the
advantages of creating fewer individual variables to keep track off,
not being a “magic” macro that creates variables, reducing code size,
and being faster when receiving on-heap TypedArrays.

PR-URL: https://github.com/nodejs/node/pull/27920
Reviewed-By: Ben Noordhuis 
Reviewed-By: Sam Roberts 
Reviewed-By: Colin Ihrig

src: make UNREACHABLE variadic

2019-05-29T17:03:43+00:00

Eliminate warning C4003
 - not enough arguments for function-like macro invocation 'UNREACHABLE'

PR-URL: https://github.com/nodejs/node/pull/27877
Reviewed-By: Tobias Nießen 
Reviewed-By: Daniel Bevenius

src: update UNREACHABLE macro to take a string

2019-05-19T22:06:51+00:00

PR-URL: https://github.com/nodejs/node/pull/26502
Reviewed-By: Daniel Bevenius 
Reviewed-By: Refael Ackermann

src: extract common macro to util.h

2019-05-11T09:49:52+00:00

PR-URL: https://github.com/nodejs/node/pull/27512
Reviewed-By: Refael Ackermann 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell

src: prefer v8::Global over node::Persistent

2019-04-29T22:23:33+00:00

`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.

This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.

PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig

src: apply clang-tidy rule modernize-use-equals-default

2019-04-24T17:32:43+00:00

PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

crypto: add openssl specific error properties

2019-03-28T21:03:18+00:00

Don't force the user to parse the long-style OpenSSL error message,
decorate the error with the library, reason, code, function.

PR-URL: https://github.com/nodejs/node/pull/26868
Reviewed-By: Anna Henningsen 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tobias Nießen

src: inline macro DISALLOW_COPY_AND_ASSIGN

2019-03-18T01:58:22+00:00

PR-URL: https://github.com/nodejs/node/pull/26634
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann