delta/node-new.git/src/tty_wrap.h, branch sam-github-tsc

src: change env.h includes for forward declarations

2019-10-31T13:11:05+00:00

Due to how the Environment class is used through the codebase,
there are a lot of includes referencing either env.h or env-inl.h.
This can cause that when any development touches those libraries,
a lot of files have to be recompiled.
This commit attempts to change those includes by forward declarations
when possible to mitigate the issue.

Refs: https://github.com/nodejs/node/issues/27531

PR-URL: https://github.com/nodejs/node/pull/30133
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: David Carlier 
Reviewed-By: Franziska Hinkelmann

src: move guessHandleType in the util binding

2019-04-20T05:25:41+00:00

It does not make too much sense to have modules unrelated to TTY
load the TTY binding just to use this method. Put this in the
util binding instead.

PR-URL: https://github.com/nodejs/node/pull/27289
Reviewed-By: Richard Lau 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Colin Ihrig

src: fix type mismatch warnings from missing priv

2018-12-04T03:44:15+00:00

Registration initialization functions are expected to have a 4th
argument, a void*, so add them where necessary to fix the warnings.

PR-URL: https://github.com/nodejs/node/pull/24737
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: remove unused UVHandle methods

2018-10-15T10:00:00+00:00

PR-URL: https://github.com/nodejs/node/pull/23535
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

src: add proper MemoryInfoName to wrappers

2018-07-27T07:51:19+00:00

- Use camel case names for memory retainers inherited from AsyncWrap
  instead of their provider names (which are all in upper case)
- Assign class names to wraps so that they appear in the heap snapshot
  as nodes with class names as node names. Previously some nodes are
  named with reference names, which are supposed to be edge names
  instead.

PR-URL: https://github.com/nodejs/node/pull/21939
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Tobias Nießen

src: enable more detailed memory tracking

2018-07-13T17:53:15+00:00

This will enable more detailed heap snapshots based on
a newer V8 API.

This commit itself is not tied to that API and could
be backported.

PR-URL: https://github.com/nodejs/node/pull/21742
Reviewed-By: James M Snell

src: remove unused include in tty_wrap.h

2017-10-25T05:43:41+00:00

This commit removes the unused handle_wrap.h and instead adds uv.h which
is used.

PR-URL: https://github.com/nodejs/node/pull/16379
Reviewed-By: Anna Henningsen 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Refael Ackermann 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen

src: rename StreamWrap to LibuvStreamWrap

2017-10-13T20:05:49+00:00

This should help clarify what kind of resource a `StreamWrap`
represents.

PR-URL: https://github.com/nodejs/node/pull/16157
Reviewed-By: Daniel Bevenius 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell 
Reviewed-By: Timothy Gu 
Reviewed-By: Joyee Cheung

tty_wrap: throw when uv_tty_init() returns error

2017-05-10T20:21:53+00:00

Also add checks in lib/tty.js and tests.

PR-URL: https://github.com/nodejs/node/pull/12892
Ref: https://github.com/nodejs/node/pull/11883
Ref: https://github.com/nodejs/node/pull/8531
Reviewed-By: Andreas Madsen 
Reviewed-By: Anna Henningsen 
Reviewed-By: Sam Roberts 
Reviewed-By: Matteo Collina 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell 
Reviewed-By: Jeremiah Senkpiel