delta/node-new.git/src/timer_wrap.h, branch stabilize-modules

src: refactor TimerWrap lifetime management

2020-07-14T13:04:46+00:00

Split `Stop(true)` and `Stop(false)` into separate methods since the
actions performed by these are fully distinct.

PR-URL: https://github.com/nodejs/node/pull/34252
Reviewed-By: James M Snell 
Reviewed-By: Zeyu Yang 
Reviewed-By: David Carlier

src: remove user_data from TimerWrap

2020-07-14T13:04:43+00:00

There’s no point in having an opaque user data pointer when we’re
already using `std::function`.

PR-URL: https://github.com/nodejs/node/pull/34252
Reviewed-By: James M Snell 
Reviewed-By: Zeyu Yang 
Reviewed-By: David Carlier

src: add TimerWrap utility

2020-07-05T21:56:59+00:00

Consolidate uv_timer_t boilerplate code into a shared utility.
There are several places throughout the code where we use uv_timer_t
internally (inspector, perf, quic), with some code duplication.
This eliminates the duplicated code, ensures that cleanup occurs
correctly, and simplifies use of the timers.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/34186
Reviewed-By: Anna Henningsen 
Reviewed-By: Matteo Collina