delta/node-new.git/src/string_search.h, branch main

src: fix return type of method in string_search.h

2021-02-10T13:26:08+00:00

`Vector::forward()` is supposed to return a `bool`.

PR-URL: https://github.com/nodejs/node/pull/37167
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott

src: fix warning in string_search.h

2021-02-04T18:46:27+00:00

Fixes: https://github.com/nodejs/node/issues/37145

PR-URL: https://github.com/nodejs/node/pull/37146
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Tobias Nießen

src: fix -Wmaybe-uninitialized compiler warning

2020-03-11T15:57:53+00:00

Turn the `strategy_` method pointer into an enum-based static dispatch.

It's both safer and more secure (no chance of method pointer corruption)
and it helps GCC see that the shift and suffix tables it's complaining
about are unused in single char search mode.

Fixes the following warning:

    ../src/string_search.h:113:30: warning:
    ‘search’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         return (this->*strategy_)(subject, index);

Fixes: https://github.com/nodejs/node/issues/26733
Refs: https://github.com/nodejs/node/pull/31532
Refs: https://github.com/nodejs/node/pull/31798
PR-URL: https://github.com/nodejs/node/pull/31809
Reviewed-By: Michaël Zasso 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Denys Otrishko 
Reviewed-By: David Carlier 
Reviewed-By: Sam Roberts 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

src: remove redundant cast in string_search.h

2019-03-06T23:31:39+00:00

PR-URL: https://github.com/nodejs/node/pull/26426
Reviewed-By: Richard Lau 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ruben Bridgewater

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove unused variable from string_search.h

2018-12-31T03:45:14+00:00

PR-URL: https://github.com/nodejs/node/pull/25139
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: Richard Lau 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca

src: use DCHECK_* macros where possible

2018-12-26T17:25:19+00:00

PR-URL: https://github.com/nodejs/node/pull/25207
Reviewed-By: Michaël Zasso 
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca

src: fix typo string_search.h comment

2018-06-03T22:52:56+00:00

PR-URL: https://github.com/nodejs/node/pull/21115
Reviewed-By: Anna Henningsen 
Reviewed-By: Vse Mozhet Byt 
Reviewed-By: Richard Lau 
Reviewed-By: Jon Moss 
Reviewed-By: Trivikram Kamat

src: remove static variables from string_search

2018-05-09T18:18:27+00:00

These variables can as well be stack-allocated. This avoids
relying on global state that is not protected by mutexes.

Thanks to Stephen Belanger for reviewing this change in its original PR.

Refs: https://github.com/ayojs/ayo/pull/82

PR-URL: https://github.com/nodejs/node/pull/20541
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis