delta/node-new.git/src/string_bytes.h, branch try_Python3_on_macOS

src: add error codes to errors thrown in C++

2019-08-09T22:58:58+00:00

PR-URL: https://github.com/nodejs/node/pull/27700
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott

src: fulfill Maybe contract in InlineDecoder

2018-12-30T19:15:39+00:00

Use an empty/nothing `Maybe<>` to indicate a pending exception.

PR-URL: https://github.com/nodejs/node/pull/25140
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: Shelley Vohr 
Reviewed-By: James M Snell

src: allow UTF-16 in generic StringBytes decode call

2018-09-03T20:33:42+00:00

This allows removing a number of special cases in other
parts of the code, at least one of which was incorrect
in expecting aligned input when that was not guaranteed.

Fixes: https://github.com/nodejs/node/issues/22358

PR-URL: https://github.com/nodejs/node/pull/22622
Reviewed-By: Tobias Nießen

src: warn about odd UTF-16 decoding function signature

2018-09-03T20:32:06+00:00

Using a `uint16_t` sequence for UTF-16 processing would typically
imply that the sequence already contains the correct 16-bit
code units.

However, our API does not account for that. The previous comments
were somewhat misleading, since endianness is typically applied to
sequences of bytes, which is not something that this API works with.

PR-URL: https://github.com/nodejs/node/pull/22623
Reviewed-By: Colin Ihrig

src: rework (mostly internal) functions to use Maybes

2018-09-02T12:25:16+00:00

Rework all affected functions to use Maybes, thus improving error
handling substantially in internal functions, API functions as well as
utilities.

Co-authored-by: Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: use String::Write{OneByte,Utf8} with isolate

2018-08-29T10:28:14+00:00

PR-URL: https://github.com/nodejs/node/pull/22531
Reviewed-By: Colin Ihrig 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: fix fs.write() externalized string handling

2018-01-23T18:17:39+00:00

* Respect `encoding` argument when the string is externalized.

* Copy the string when the write request can outlive the externalized
  string.

This commit removes `StringBytes::GetExternalParts()` because it is
fundamentally broken.

Fixes: https://github.com/nodejs/node/issues/18146
PR-URL: https://github.com/nodejs/node/pull/18216
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: remove unused includes in string_bytes.h

2017-11-01T07:44:46+00:00

PR-URL: https://github.com/nodejs/node/pull/16606
Reviewed-By: Gireesh Punathil 
Reviewed-By: XadillaX 
Reviewed-By: Tobias Nießen 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Joyee Cheung 
Reviewed-By: Colin Ihrig

src: do not include x.h if x-inl.h is included

2017-10-30T10:56:38+00:00

PR-URL: https://github.com/nodejs/node/pull/16548
Fixes: https://github.com/nodejs/node/issues/16519
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Gibson Fahnestock 
Reviewed-By: Colin Ihrig

src: remove unused parameters

2017-05-22T20:09:27+00:00

PR-URL: https://github.com/nodejs/node/pull/13085
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ron Korving 
Reviewed-By: James M Snell 
Reviewed-By: Daniel Bevenius