delta/node-new.git/src/stream_wrap.h, branch crypto_set_integer_macro

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: remove StreamBase::kFlagHasWritev

2018-06-30T13:52:54+00:00

Since libuv 1.21.0, pipes on Windows support `writev` on the
libuv side.

This allows for some simplification, and makes the `StreamBase`
API more uniform (multi-buffer `Write()` is always supported now,
including when used by other non-JS consumers like HTTP/2).

PR-URL: https://github.com/nodejs/node/pull/21527
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: remove extra `ReadStop()` call

2018-06-30T13:51:40+00:00

This is no longer necessary since libuv 1.21.0.

PR-URL: https://github.com/nodejs/node/pull/21528
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: always call ReadStop() before Close()

2018-05-10T12:15:18+00:00

For libuv-backed streams, always explicitly stop reading before
closing the handle.

PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell

src: store fd for libuv streams on Windows

2018-05-10T12:15:17+00:00

On Windows, we can't just look up a FD for libuv streams and
return it in `GetFD()`.
However, we do sometimes construct streams from their FDs;
in those cases, it should be okay to store the value on a class field.

PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell

src: refactor WriteWrap and ShutdownWraps

2018-02-14T09:00:29+00:00

Encapsulate stream requests more:

- `WriteWrap` and `ShutdownWrap` classes are now tailored to the
  streams on which they are used. In particular, for most streams
  these are now plain `AsyncWrap`s and do not carry the overhead
  of unused libuv request data.
- Provide generic `Write()` and `Shutdown()` methods that wrap
  around the actual implementations, and make *usage* of streams
  easier, rather than implementing; for example, wrap objects
  don’t need to be provided by callers anymore.
- Use `EmitAfterWrite()` and `EmitAfterShutdown()` handlers to
  call the corresponding JS handlers, rather than always trying
  to call them. This makes usage of streams by other C++ code
  easier and leaner.

Also fix up some tests that were previously not actually testing
asynchronicity when the comments indicated that they would.

PR-URL: https://github.com/nodejs/node/pull/18676
Reviewed-By: Ben Noordhuis 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: James M Snell

src: simplify handles for libuv streams

2018-02-01T09:53:53+00:00

Instead of passing along the handle object, just set it as a
property on the stream handle object and let the read handler
grab it from there.

PR-URL: https://github.com/nodejs/node/pull/18334
Reviewed-By: James M Snell 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Matteo Collina

src: refactor stream callbacks and ownership

2018-02-01T09:53:26+00:00

Instead of setting individual callbacks on streams and tracking
stream ownership through a boolean `consume_` flag, always have
one specific listener object in charge of a stream, and call
methods on that object rather than generic C-style callbacks.

PR-URL: https://github.com/nodejs/node/pull/18334
Reviewed-By: James M Snell 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Matteo Collina

src: remove `HasWriteQueue()`

2018-01-14T13:41:14+00:00

Tests are passing without it, and this otherwise makes the
code harder to reason about because the `async` flag on the
write request object would not be set even though the callback
would still be pending.

PR-URL: https://github.com/nodejs/node/pull/18019
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

net,src: refactor writeQueueSize tracking

2017-12-18T14:58:02+00:00

Currently, writeQueueSize is never used in C++ and barely used
within JS. Instead of constantly updating the value on the JS
object, create a getter that will retrieve the most up-to-date
value from C++.

For the vast majority of cases though, create a new prop on
Socket.prototype[kLastWriteQueueSize] using a Symbol. Use this
to track the current write size, entirely in JS land.

PR-URL: https://github.com/nodejs/node/pull/17650
Reviewed-By: Anna Henningsen