delta/node-new.git/src/stream_wrap.cc, branch devsnek-patch-1

src: retrieve binding data from the context

2020-05-06T04:44:04+00:00

Instead of passing them through the data bound to function
templates, store references to them in a list embedded inside
the context.
This makes the function templates more context-independent,
and makes it possible to embed binding data in non-main contexts.

Co-authored-by: Anna Henningsen 

PR-URL: https://github.com/nodejs/node/pull/33139
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung

src: make creating per-binding data structures easier

2020-04-06T00:06:35+00:00

Enable the state associated with the individual bindings, e.g. fs or
http2, to be moved out of the Environment class, in order for these
to be more modular and for Environment to be come less of a collection
of random data fields.

Do this by using a BaseObject as the data for callbacks, which can hold
the per-binding state. By default, no per-binding state is available,
although that can be configured when setting up the binding.

PR-URL: https://github.com/nodejs/node/pull/32538
Reviewed-By: James M Snell

src: clean up stream_base.h and stream-base-inl.h

2020-03-19T12:22:53+00:00

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/32307
Reviewed-By: Anna Henningsen 
Reviewed-By: Jiawen Geng

src: improve handling of internal field counting

2020-03-02T18:58:36+00:00

Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/31960
Reviewed-By: Anna Henningsen 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina

src: persist strings that are used multiple times in the environment

2019-11-08T22:50:04+00:00

PR-URL: https://github.com/nodejs/node/pull/30321
Reviewed-By: Anna Henningsen 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: David Carlier 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: store onread callback in internal field

2019-03-26T13:48:56+00:00

This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%

PR-URL: https://github.com/nodejs/node/pull/26837
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

src: remove templating from StreamBase

2019-03-08T08:25:30+00:00

PR-URL: https://github.com/nodejs/node/pull/25142
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use object to pass `Environment` to functions

2019-03-04T23:56:37+00:00

Use a `v8::Object` with an internal field, rather than a
`v8::External`.

On a `GetReturnValue().Set(Environment::GetCurrent(args) == nullptr)`
noop function, this benchmarks as a ~60 % speedup, as calls to
`obj->GetAlignedPointerFromInternalField()` can be inlined and
the field is stored with one level of indirection less.

This also makes breaking up some pieces of the `Environment` class
into per-native-binding data easier, if we want to pursue that path
in the future.

PR-URL: https://github.com/nodejs/node/pull/26382
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell