delta/node-new.git/src/stream_base.cc, branch pull-request-doc-updates

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: add DCHECK macros

2018-12-24T09:41:15+00:00

This adds check statements for debugging and refactors the code
accordingly.

PR-URL: https://github.com/nodejs/node/pull/24359
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ruben Bridgewater

src: fix v8 compiler warnings in src

2018-11-11T07:02:30+00:00

This commit changes the code to use the maybe version.

PR-URL: https://github.com/nodejs/node/pull/24246
Reviewed-By: Anna Henningsen 
Reviewed-By: Refael Ackermann

src: fix compiler warning for debug build

2018-11-03T07:13:09+00:00

This commit updates the check of the offset argument passed to
CallJSOnreadMethod to avoid doing a cast as this currently generates
the following compiler warning when doing a debug build:

./src/stream_base.cc:295:3:
warning: comparison of integers of different signs:
'int32_t' (aka 'int') and 'size_t' (aka 'unsigned long')
[-Wsign-compare]
  CHECK_EQ(static_cast(offset), offset);
  ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~

PR-URL: https://github.com/nodejs/node/pull/23994
Reviewed-By: Anna Henningsen 
Reviewed-By: Matheus Marchini 
Reviewed-By: Luigi Pinca 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell

src: improve StreamBase write throughput

2018-10-28T14:15:15+00:00

Improve performance by transferring information about write status
to JS through an `AliasedBuffer`, rather than object properties
set from C++.

PR-URL: https://github.com/nodejs/node/pull/23843
Reviewed-By: James M Snell 
Reviewed-By: Anatoli Papirovski

src: improve StreamBase read throughput

2018-10-24T07:57:42+00:00

Improve performance by providing JS with the raw ingridients
for the read data, i.e. an `ArrayBuffer` + offset + length
fields, instead of creating `Buffer` instances in C++ land.

PR-URL: https://github.com/nodejs/node/pull/23797
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell

src: use MallocedBuffer abstraction for buffers

2018-10-15T10:03:08+00:00

Drop `Free` and `std::unique_ptr` in favor of Node's `MallocedBuffer`
for `char[]` buffer memory mangement.

PR-URL: https://github.com/nodejs/node/pull/23543
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Franziska Hinkelmann

src: reduce variable scope in stream_base.cc

2018-10-09T12:33:38+00:00

PR-URL: https://github.com/nodejs/node/pull/23297
Reviewed-By: Anna Henningsen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Refael Ackermann 
Reviewed-By: Gabriel Schulhof 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: James M Snell

src: rework (mostly internal) functions to use Maybes

2018-09-02T12:25:16+00:00

Rework all affected functions to use Maybes, thus improving error
handling substantially in internal functions, API functions as well as
utilities.

Co-authored-by: Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: re-add `Realloc()` shrink after reading stream data

2018-06-13T00:46:15+00:00

This would otherwise keep a lot of unused memory lying around,
and in particular add up to a page per chunk of memory overhead
for network reads, potentially opening a DoS vector if the resulting
`Buffer` objects are kept around indefinitely (e.g. stored in a list
and not concatenated until the socket finishes).

This fixes CVE-2018-7164.

Refs: https://github.com/nodejs-private/security/issues/186
Refs: https://github.com/nodejs/node/commit/7c4b09b24bbe7d6a8cbad256f47b30a101a909ea
PR-URL: https://github.com/nodejs-private/node-private/pull/128
Reviewed-By: Michael Dawson 
Reviewed-By: Evan Lucas