delta/node-new.git/src/spawn_sync.h, branch crypto_set_integer_macro

src: use default initializers over settings fields on the constructor

2018-10-15T10:03:08+00:00

PR-URL: https://github.com/nodejs/node/pull/23532
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

src: rework (mostly internal) functions to use Maybes

2018-09-02T12:25:16+00:00

Rework all affected functions to use Maybes, thus improving error
handling substantially in internal functions, API functions as well as
utilities.

Co-authored-by: Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: remove using directives from spawn_sync.h

2018-07-05T04:12:35+00:00

I noticed that there were a few using declarations what were unused and
instead of just removing them, this commit removes all of them and uses
qualified names instead since they are in a header.

PR-URL: https://github.com/nodejs/node/pull/21634
Reviewed-By: Colin Ihrig

src: make ownership of stdio_pipes explicit

2017-11-16T15:54:00+00:00

Use smart pointers instead of raw pointers for StdioPipes.
Also, use a smart pointer for the array holding them.

PR-URL: https://github.com/nodejs/node/pull/17030
Reviewed-By: Colin Ihrig

src: do not include internals from node_buffer.h

2017-09-22T14:28:52+00:00

`node_buffer.h` is a public header, so it should not be using
the `node_internals.h` internal header.

Ref: 290315ace7eed6eeeb300754dd68fc1af4d80c9b
Fixes: https://github.com/nodejs/node/issues/15552
PR-URL: https://github.com/nodejs/node/pull/15554
Reviewed-By: Matteo Collina 
Reviewed-By: Andreas Madsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Gibson Fahnestock

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

child_process: allow Infinity as maxBuffer value

2017-01-17T15:47:28+00:00

Fixes: https://github.com/nodejs/node/pull/10767
PR-URL: https://github.com/nodejs/node/pull/10769
Reviewed-By: James M Snell

src: fix bad logic in uid/gid checks

2016-06-29T10:21:13+00:00

Pointed out by Coverity.  Introduced in commits 3546383c ("process_wrap:
avoid leaking memory when throwing due to invalid arguments") and
fa4eb47c ("bindings: add spawn_sync bindings").

The return statements inside the if blocks were dead code because their
guard conditions always evaluated to false.  Remove them.

PR-URL: https://github.com/nodejs/node/pull/7374
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Michael Dawson

src: fix readability/namespace cpplint warnings

2016-06-28T19:21:21+00:00

PR-URL: https://github.com/nodejs/node/pull/7462
Reviewed-By: Trevor Norris

src: add include guards to internal headers

2016-05-25T07:54:24+00:00

For consistency with the newly added src/base64.h header, check that
NODE_WANT_INTERNALS is defined and set in internal headers.

PR-URL: https://github.com/nodejs/node/pull/6948
Refs: https://github.com/nodejs/node/pull/6910
Reviewed-By: Fedor Indutny 
Reviewed-By: James M Snell 
Reviewed-By: Trevor Norris