delta/node-new.git/src/spawn_sync.cc, branch pull-request-doc-updates

src: turn ROUND_UP into an inline function

2019-01-30T22:40:37+00:00

PR-URL: https://github.com/nodejs/node/pull/25743
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tiancheng "Timothy" Gu

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use isolate version of BooleanValue()

2018-12-09T06:42:05+00:00

This fixes deprecation warnings.

PR-URL: https://github.com/nodejs/node/pull/24883
Reviewed-By: Michaël Zasso 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: fix type mismatch warnings from missing priv

2018-12-04T03:44:15+00:00

Registration initialization functions are expected to have a 4th
argument, a void*, so add them where necessary to fix the warnings.

PR-URL: https://github.com/nodejs/node/pull/24737
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: changed stdio_pipes_ to std::vector

2018-10-17T17:20:43+00:00

PR-URL: https://github.com/nodejs/node/pull/23615
Reviewed-By: Sam Ruby 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Refael Ackermann

src: use default initializers over settings fields on the constructor

2018-10-15T10:03:08+00:00

PR-URL: https://github.com/nodejs/node/pull/23532
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater

child_process: move process.binding('spawn_sync') to internalBinding

2018-09-15T11:48:44+00:00

PR-URL: https://github.com/nodejs/node/pull/22260
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Trivikram Kamat 
Reviewed-By: John-David Dalton 
Reviewed-By: Denys Otrishko 
Reviewed-By: Ruben Bridgewater

src: remove calls to deprecated V8 functions (Int32Value)

2018-09-05T10:59:25+00:00

Remove all calls to deprecated V8 functions (here: Value::Int32Value)
inside the code.

PR-URL: https://github.com/nodejs/node/pull/22662
Reviewed-By: Anna Henningsen 
Reviewed-By: Minwoo Jung 
Reviewed-By: James M Snell 
Reviewed-By: Ujjwal Sharma

src: rework (mostly internal) functions to use Maybes

2018-09-02T12:25:16+00:00

Rework all affected functions to use Maybes, thus improving error
handling substantially in internal functions, API functions as well as
utilities.

Co-authored-by: Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen

src: remove calls to deprecated v8 functions (ToString)

2018-09-02T12:24:58+00:00

Remove all calls to deprecated v8 functions (here: Value::ToString)
inside the code (src directory only).

PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen