delta/node-new.git/src/spawn_sync.cc, branch Ninja.py-StringIO

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: apply clang-tidy rule modernize-use-equals-default

2019-04-24T17:32:43+00:00

PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: apply clang-tidy rule modernize-deprecated-headers

2019-02-27T04:35:53+00:00

PR-URL: https://github.com/nodejs/node/pull/26159
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: turn ROUND_UP into an inline function

2019-01-30T22:40:37+00:00

PR-URL: https://github.com/nodejs/node/pull/25743
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Tiancheng "Timothy" Gu

src: reduce includes of node_internals.h

2019-01-21T06:54:42+00:00

PR-URL: https://github.com/nodejs/node/pull/25507
Reviewed-By: Daniel Bevenius 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: use isolate version of BooleanValue()

2018-12-09T06:42:05+00:00

This fixes deprecation warnings.

PR-URL: https://github.com/nodejs/node/pull/24883
Reviewed-By: Michaël Zasso 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: fix type mismatch warnings from missing priv

2018-12-04T03:44:15+00:00

Registration initialization functions are expected to have a 4th
argument, a void*, so add them where necessary to fix the warnings.

PR-URL: https://github.com/nodejs/node/pull/24737
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: changed stdio_pipes_ to std::vector

2018-10-17T17:20:43+00:00

PR-URL: https://github.com/nodejs/node/pull/23615
Reviewed-By: Sam Ruby 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Refael Ackermann

src: use default initializers over settings fields on the constructor

2018-10-15T10:03:08+00:00

PR-URL: https://github.com/nodejs/node/pull/23532
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Ruben Bridgewater