delta/node-new.git/src/pipe_wrap.cc, branch devsnek-patch-1

src: use env->ThrowUVException in pipe_wrap

2020-10-06T11:38:54+00:00

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/35493
Reviewed-By: Daijiro Wachi 
Reviewed-By: Tobias Nießen 
Reviewed-By: David Carlier 
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

src: improve handling of internal field counting

2020-03-02T18:58:36+00:00

Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/31960
Reviewed-By: Anna Henningsen 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina

src: refactor deprecated UVException usage in pipe-wrap.cc

2019-05-10T09:36:27+00:00

PR-URL: https://github.com/nodejs/node/pull/27562
Reviewed-By: Anna Henningsen 
Reviewed-By: Rich Trott 
Reviewed-By: Anto Aravinth 
Reviewed-By: Colin Ihrig

src: replace FromJust() with Check() when possible

2019-04-12T19:33:37+00:00

FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:

  To be used, where the actual value of the Maybe is not needed, like
  Object::Set.

See: https://github.com/nodejs/node/pull/26929/files#r269256335

PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Michaël Zasso 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: Yongsheng Zhang

src: move AsyncHooks out of Environment

2019-03-27T14:30:09+00:00

PR-URL: https://github.com/nodejs/node/pull/26824
Refs: https://github.com/nodejs/node/issues/26776
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: store onread callback in internal field

2019-03-26T13:48:56+00:00

This gives a slight performance improvement. At 2000 runs:

                                            confidence improvement accuracy (*)   (**)  (***)
    net/net-c2s.js dur=5 type='buf' len=64        ***      0.54 %       ±0.16% ±0.21% ±0.27%

PR-URL: https://github.com/nodejs/node/pull/26837
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis

src: remove templating from StreamBase

2019-03-08T08:25:30+00:00

PR-URL: https://github.com/nodejs/node/pull/25142
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: remove redundant cast in PipeWrap::Fchmod

2019-03-01T23:12:16+00:00

PR-URL: https://github.com/nodejs/node/pull/26242
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater

src: pass along errors from stream obj instantiation

2019-01-29T19:01:59+00:00

PR-URL: https://github.com/nodejs/node/pull/25734
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan