delta/node-new.git/src/node_zlib.cc, branch docs-fix

zlib: switch to lazy init for zlib streams

2020-07-22T13:20:33+00:00

PR-URL: https://github.com/nodejs/node/pull/34048
Reviewed-By: Anna Henningsen

src: remove unused using declarations

2020-05-28T14:02:14+00:00

This commit removes the unused using declarations reported by lint-cpp.

PR-URL: https://github.com/nodejs/node/pull/33268
Refs: https://github.com/nodejs/node/issues/29226
Reviewed-By: Ben Noordhuis 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Christian Clauss 
Reviewed-By: Daniel Bevenius 
Reviewed-By: Beth Griggs

src: fix invalid windowBits=8 gzip segfault

2020-05-09T05:54:38+00:00

`{ windowBits: 8 }` is legal for deflate streams but not gzip streams.
Fix a nullptr dereference when formatting the error message.

Bug introduced in commit c34eae5f88 ("zlib: refactor zlib internals")
from September 2018.

PR-URL: https://github.com/nodejs/node/pull/33045
Reviewed-By: Anna Henningsen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: David Carlier

src: improve handling of internal field counting

2020-03-02T18:58:36+00:00

Change suggested by bnoordhuis.

Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.

Signed-off-by: James M Snell 

PR-URL: https://github.com/nodejs/node/pull/31960
Reviewed-By: Anna Henningsen 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Matteo Collina

src: remove duplicate field env in CryptoJob class

2020-02-02T17:06:42+00:00

Removed field env from cryptojob class, replaced with
function env() inherited from ThreadPoolWork

PR-URL: https://github.com/nodejs/node/pull/31554
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Rich Trott 
Reviewed-By: Tobias Nießen

src: migrate off ArrayBuffer::GetContents

2019-11-12T05:29:23+00:00

V8 deprecates `GetContents()` in favour of `GetBackingStore()`.
Update our code to reflect that.
V8 also deprecates `Externalize()` and `IsExternal()`; we should
be able to remove all usage of this once V8 8.0 is there.

PR-URL: https://github.com/nodejs/node/pull/30339
Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34
Reviewed-By: Gus Caplan 
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Jiawen Geng 
Reviewed-By: David Carlier

src: do not use `std::function` for `OnScopeLeave`

2019-11-07T09:39:40+00:00

Using `std::function` adds an extra layer of indirection, and in
particular, heap allocations that are not necessary in our use case
here.

PR-URL: https://github.com/nodejs/node/pull/30134
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: James M Snell

src: remove memory_tracker-inl.h from header files

2019-05-23T15:51:39+00:00

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: move ThreadPoolWork inlines into a -inl.h

2019-05-23T15:51:33+00:00

The presence of the inline definitions in node_internals.h can cause all
files that include node_internals.h to depend on util-inl.h, even if
they never use ThreadPoolWork. Whether this happens depends on the
toolchain, gcc will strip unused definitions, clang won't.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: prefer v8::Global over node::Persistent

2019-04-29T22:23:33+00:00

`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.

This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.

PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Joyee Cheung 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig