delta/node-new.git/src/node_zlib.cc, branch crypto_set_integer_macro

zlib: refactor zlib internals

2018-10-16T03:26:20+00:00

Split out things that are specific to zlib as a specific
compression library, vs. the interface that is common to
most C compression libraries.

This should pave the way for including support for e.g.
brotli.

PR-URL: https://github.com/nodejs/node/pull/23360
Reviewed-By: James M Snell 
Reviewed-By: Daniel Bevenius

zlib: move process.binding('zlib') to internalBinding

2018-10-12T21:57:16+00:00

PR-URL: https://github.com/nodejs/node/pull/23307
Reviewed-By: Colin Ihrig 
Reviewed-By: Gus Caplan 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Weijia Wang 
Reviewed-By: James M Snell 
Reviewed-By: Sakthipriyan Vairamani

zlib: generate error code names in C++

2018-10-12T21:29:52+00:00

This makes it easier to implement the lookup in a way that targets
error codes from a specific compression library, as a way towards
supporting multiple ones (e.g. brotli).

PR-URL: https://github.com/nodejs/node/pull/23413
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Sakthipriyan Vairamani 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: name EmbededderGraph edges and use class names for nodes

2018-10-04T13:32:30+00:00

This patch:

- Refactors the `MemoryRetainer` API so that the impementer no longer
  calls `TrackThis()` that sets the size of node on the top of the
  stack, which may be hard to understand. Instead now they implements
  `SelfSize()` to provide their self sizes. Also documents
  the API in the header.
- Refactors `MemoryTracker` so it calls `MemoryInfoName()` and
  `SelfSize()` of `MemoryRetainer` to retrieve info about them, and
  separate `node_names` and `edge_names` so the edges can be properly
  named with reference names and the nodes can be named with class
  names. (Previously the nodes are named with reference names while the
  edges are all indexed and appear as array elements).
- Adds `SET_MEMORY_INFO_NAME()`, `SET_SELF_SIZE()` and
  `SET_NO_MEMORY_INFO()` convenience macros
- Fixes a few `MemoryInfo` calls in some `MemoryRetainers` to track
  their references properly.
- Refactors the heapdump tests to check both node names and edge names,
  distinguishing between wrapped JS nodes (without prefixes)
  and embedder wrappers (prefixed with `Node / `).

PR-URL: https://github.com/nodejs/node/pull/23072
Reviewed-By: Anna Henningsen

src: clean up zlib write code

2018-10-04T10:37:50+00:00

Split the existing `Write()` method into one that takes care
of translating the arguments from JS to C++, and a non-static
method for the actual write operations, as well as some minor
stylistic drive-by fixes.

PR-URL: https://github.com/nodejs/node/pull/23183
Reviewed-By: James M Snell 
Reviewed-By: Daniel Bevenius

src: use JS inheritance for `AsyncWrap`

2018-10-03T20:43:42+00:00

For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.

This allows cleanup of some code around transferring handles
over IPC.

PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung 
Reviewed-By: Daniel Bevenius 
Reviewed-By: James M Snell

src: define zlib constants in node_zlib.cc

2018-09-25T03:49:49+00:00

This is in order to avoid having two separate definitions
for `node_zlib_mode`.

PR-URL: https://github.com/nodejs/node/pull/23019
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: make `ZCtx::Init()` non-static

2018-09-25T03:49:46+00:00

PR-URL: https://github.com/nodejs/node/pull/23019
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: refactor zlib dictionary to STL vector

2018-09-25T03:49:34+00:00

PR-URL: https://github.com/nodejs/node/pull/23019
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan

src: replace deprecated uses of FunctionTemplate::GetFunction

2018-09-24T03:44:28+00:00

PR-URL: https://github.com/nodejs/node/pull/22993
Reviewed-By: Michaël Zasso 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ujjwal Sharma 
Reviewed-By: Joyee Cheung 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell