delta/node-new.git/src/node_worker.h, branch sam-github-tsc

worker: add stack size resource limit option

2020-04-29T03:13:42+00:00

Add `stackSizeMb` to the `resourceLimit` option group.

Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820

PR-URL: https://github.com/nodejs/node/pull/33085
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

worker: unify custom error creation

2020-04-29T03:12:48+00:00

Mostly, this introduces a pattern that makes sure that if a custom
error is reported, `stopped_` will be set to `true` correctly in
every cast, which was previously missing for the
`NewContext().IsEmpty()` case (which led to a hard crash from the
`Worker` destructor).

This also leaves TODO comments for a few cases in which
`ERR_WORKER_OUT_OF_MEMORY` was not used in accordance with the
documentation for that error code (or according to its intention).
Fixing that is semver-major.

PR-URL: https://github.com/nodejs/node/pull/33084
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: remove loop_init_failed_ from Worker class

2020-04-02T16:13:09+00:00

There’s no reason for this to not be stored alongside the loop
data structure itself.

PR-URL: https://github.com/nodejs/node/pull/32562
Refs: https://github.com/nodejs/node/pull/32344
Reviewed-By: Colin Ihrig 
Reviewed-By: Denys Otrishko 
Reviewed-By: James M Snell

src: align worker and main thread code with embedder API

2020-03-21T09:57:20+00:00

This addresses some long-standing TODOs by Joyee and me about
making the embedder API more powerful and us less reliant on
internal APIs for creating the main thread and Workers.

PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell 
Reviewed-By: Gireesh Punathil

worker: emit runtime error on loop creation failure

2020-02-19T18:54:59+00:00

Instead of hard asserting throw a runtime error,
that is more consumable.

Fixes: https://github.com/nodejs/node/issues/31614

PR-URL: https://github.com/nodejs/node/pull/31621
Reviewed-By: Anna Henningsen

worker: properly handle env and NODE_OPTIONS in workers

2020-02-13T15:05:27+00:00

PR-URL: https://github.com/nodejs/node/pull/31711
Fixes: https://github.com/nodejs/node/issues/30627
Reviewed-By: Anna Henningsen 
Reviewed-By: Benjamin Gruenbaum

src: remove unused `Worker::child_port_` member

2020-02-04T06:02:34+00:00

This fixes a compiler warning introduced in 9225939528590f652e6.

PR-URL: https://github.com/nodejs/node/pull/31599
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

worker: add ability to take heap snapshot from parent thread

2020-02-03T15:04:13+00:00

PR-URL: https://github.com/nodejs/node/pull/31569
Reviewed-By: Denys Otrishko 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan 
Reviewed-By: Colin Ihrig 
Reviewed-By: Richard Lau 
Reviewed-By: Rich Trott

src: move MemoryInfo() for worker code to .cc files

2020-01-21T22:51:37+00:00

This is a) the right thing to do anyway because these functions
can not be inlined by the compiler and b) avoids compilation warnings
in the following commit.

PR-URL: https://github.com/nodejs/node/pull/31386
Refs: https://github.com/openjs-foundation/summit/pull/240
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott

src: add interrupts to Environments/Workers

2020-01-21T22:51:36+00:00

Allow doing what V8’s `v8::Isolate::RequestInterrupt()` does for V8.
This also works when there is no JS code currently executing.

PR-URL: https://github.com/nodejs/node/pull/31386
Refs: https://github.com/openjs-foundation/summit/pull/240
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig 
Reviewed-By: Rich Trott