delta/node-new.git/src/node_worker.cc, branch sam-github-tsc

src: disallow JS execution inside FreeEnvironment

2020-06-25T00:43:29+00:00

This addresses a TODO comment, and aligns the behavior between
worker threads and the main thread.

The primary motivation for this change is to more strictly enforce
the invariant that no JS runs after the `'exit'` event is emitted.

PR-URL: https://github.com/nodejs/node/pull/33874
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Shelley Vohr

src: use MaybeLocal.ToLocal instead of IsEmpty worker

2020-05-30T16:46:19+00:00

This commit suggest using MaybeLocal.ToLocal and passing in the
Local node_opts. It also introduces a variable, arg_v8, of type
Local to enable the use of ToLocal.

The motivation for doing this is that the following
MaybeLocal::ToLocalChecked and MaybeLocal::FromMaybe calls can then be
avoided.

PR-URL: https://github.com/nodejs/node/pull/33599
Reviewed-By: Zeyu Yang 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: use enum for refed flag on native immediates

2020-05-22T00:47:56+00:00

Refs: https://github.com/nodejs/node/pull/33320#discussion_r423141443

PR-URL: https://github.com/nodejs/node/pull/33444
Reviewed-By: James M Snell 
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Ben Noordhuis

src: distinguish refed/unrefed threadsafe Immediates

2020-05-16T10:14:15+00:00

In some situations, it can be useful to use threadsafe callbacks
on an `Environment` to perform cleanup operations that should run
even when the process would otherwise be ending.

PR-URL: https://github.com/nodejs/node/pull/33320
Reviewed-By: James M Snell

worker: fix crash when .unref() is called during exit

2020-05-16T09:13:30+00:00

To be more precise, fix a crash when `worker.unref()` is called
from a message on the Worker that is not emitted before the Worker
thread has stopped.

PR-URL: https://github.com/nodejs/node/pull/33394
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

worker: call CancelTerminateExecution() before exiting Locker

2020-05-15T17:38:23+00:00

As the comment indicates, this fixes a DCHECK failure, although I don’t
quite understand why it is happening in the first place.

PR-URL: https://github.com/nodejs/node/pull/33347
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: David Carlier

worker: add stack size resource limit option

2020-04-29T03:13:42+00:00

Add `stackSizeMb` to the `resourceLimit` option group.

Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820

PR-URL: https://github.com/nodejs/node/pull/33085
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

worker: unify custom error creation

2020-04-29T03:12:48+00:00

Mostly, this introduces a pattern that makes sure that if a custom
error is reported, `stopped_` will be set to `true` correctly in
every cast, which was previously missing for the
`NewContext().IsEmpty()` case (which led to a hard crash from the
`Worker` destructor).

This also leaves TODO comments for a few cases in which
`ERR_WORKER_OUT_OF_MEMORY` was not used in accordance with the
documentation for that error code (or according to its intention).
Fixing that is semver-major.

PR-URL: https://github.com/nodejs/node/pull/33084
Reviewed-By: Gireesh Punathil 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

src: remove unused using in node_worker.cc

2020-04-17T09:06:53+00:00

This commit removes unused using declarations in
src/node_worker.cc.

PR-URL: https://github.com/nodejs/node/pull/32840
Reviewed-By: Richard Lau 
Reviewed-By: David Carlier 
Reviewed-By: Yongsheng Zhang 
Reviewed-By: Colin Ihrig 
Reviewed-By: Luigi Pinca 
Reviewed-By: James M Snell

src: initialize inspector before RunBootstrapping()

2020-04-07T22:04:55+00:00

This is necessary for `--inspect-brk-node` to work, and for the
inspector to be aware of scripts created before bootstrapping.

Fixes: https://github.com/nodejs/node/issues/32648
Refs: https://github.com/nodejs/node/pull/30467#discussion_r396879908

PR-URL: https://github.com/nodejs/node/pull/32672
Reviewed-By: Gus Caplan 
Reviewed-By: Eugene Ostroukhov 
Reviewed-By: Joyee Cheung 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell