delta/node-new.git/src/node_worker.cc, branch docs-fix

perf_hooks: add idleTime and event loop util

2020-08-29T14:02:31+00:00

Use uv_metrics_idle_time() to return a high resolution millisecond timer
of the amount of time the event loop has been idle since it was
initialized.

Include performance.eventLoopUtilization() API to handle the math of
calculating the idle and active times. This has been added to prevent
accidental miscalculations of the event loop utilization. Such as not
taking into consideration offsetting nodeTiming.loopStart or timing
differences when being called from a Worker thread.

PR-URL: https://github.com/nodejs/node/pull/34938
Reviewed-By: James M Snell 
Reviewed-By: Adrian Estrada 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Matteo Collina 
Reviewed-By: Stephen Belanger 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Gerhard Stöbich

src: prefer C++ empty() in boolean expressions

2020-08-11T20:22:04+00:00

PR-URL: https://github.com/nodejs/node/pull/34432
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Jiawen Geng 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Franziska Hinkelmann

worker: add option to track unmanaged file descriptors

2020-07-14T13:07:20+00:00

Add a public option for Workers which adds tracking for raw
file descriptors, as currently, those resources are not cleaned
up, unlike e.g. `FileHandle`s.

PR-URL: https://github.com/nodejs/node/pull/34303
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Benjamin Gruenbaum

src: disallow JS execution inside FreeEnvironment

2020-06-25T00:43:29+00:00

This addresses a TODO comment, and aligns the behavior between
worker threads and the main thread.

The primary motivation for this change is to more strictly enforce
the invariant that no JS runs after the `'exit'` event is emitted.

PR-URL: https://github.com/nodejs/node/pull/33874
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Shelley Vohr

src: use MaybeLocal.ToLocal instead of IsEmpty worker

2020-05-30T16:46:19+00:00

This commit suggest using MaybeLocal.ToLocal and passing in the
Local node_opts. It also introduces a variable, arg_v8, of type
Local to enable the use of ToLocal.

The motivation for doing this is that the following
MaybeLocal::ToLocalChecked and MaybeLocal::FromMaybe calls can then be
avoided.

PR-URL: https://github.com/nodejs/node/pull/33599
Reviewed-By: Zeyu Yang 
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: use enum for refed flag on native immediates

2020-05-22T00:47:56+00:00

Refs: https://github.com/nodejs/node/pull/33320#discussion_r423141443

PR-URL: https://github.com/nodejs/node/pull/33444
Reviewed-By: James M Snell 
Reviewed-By: Zeyu Yang 
Reviewed-By: Colin Ihrig 
Reviewed-By: David Carlier 
Reviewed-By: Ben Noordhuis

src: distinguish refed/unrefed threadsafe Immediates

2020-05-16T10:14:15+00:00

In some situations, it can be useful to use threadsafe callbacks
on an `Environment` to perform cleanup operations that should run
even when the process would otherwise be ending.

PR-URL: https://github.com/nodejs/node/pull/33320
Reviewed-By: James M Snell

worker: fix crash when .unref() is called during exit

2020-05-16T09:13:30+00:00

To be more precise, fix a crash when `worker.unref()` is called
from a message on the Worker that is not emitted before the Worker
thread has stopped.

PR-URL: https://github.com/nodejs/node/pull/33394
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell

worker: call CancelTerminateExecution() before exiting Locker

2020-05-15T17:38:23+00:00

As the comment indicates, this fixes a DCHECK failure, although I don’t
quite understand why it is happening in the first place.

PR-URL: https://github.com/nodejs/node/pull/33347
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: David Carlier

worker: add stack size resource limit option

2020-04-29T03:13:42+00:00

Add `stackSizeMb` to the `resourceLimit` option group.

Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820

PR-URL: https://github.com/nodejs/node/pull/33085
Reviewed-By: Gireesh Punathil 
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig