delta/node-new.git/src/node_worker.cc, branch devsnek-patch-1

worker: add eventLoopUtilization()

2020-10-27T08:43:20+00:00

Allow calling eventLoopUtilization() directly on a worker thread:

    const worker = new Worker('./foo.js');
    const elu = worker.performance.eventLoopUtilization();
    setTimeout(() => {
      worker.performance.eventLoopUtilization(elu);
    }, 10);

Add a new performance object on the Worker instance that will hopefully
one day hold all the other performance metrics, such as nodeTiming.

Include benchmarks and tests.

PR-URL: https://github.com/nodejs/node/pull/35664
Reviewed-By: Juan José Arboleda 
Reviewed-By: Anna Henningsen 
Reviewed-By: Gerhard Stöbich 
Reviewed-By: James M Snell

src: add --heapsnapshot-near-heap-limit option

2020-10-21T19:41:11+00:00

This patch adds a --heapsnapshot-near-heap-limit CLI option
that takes heap snapshots when the V8 heap is approaching
the heap size limit. It will try to write the snapshots
to disk before the program crashes due to OOM.

PR-URL: https://github.com/nodejs/node/pull/33010
Refs: https://github.com/nodejs/node/issues/27552
Reviewed-By: Anna Henningsen 
Reviewed-By: Richard Lau 
Reviewed-By: Gireesh Punathil

src: add embedding helpers to reduce boilerplate code

2020-10-14T18:08:19+00:00

Provide helpers for a) spinning the event loop and
b) setting up and tearing down the objects involved in a single
Node.js instance, as they would typically be used.
The former helper is also usable inside Node.js itself,
for both Worker and main threads.

PR-URL: https://github.com/nodejs/node/pull/35597
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
Reviewed-By: Denys Otrishko

lib: add EventTarget-related browser globals

2020-10-11T14:35:17+00:00

Add

- Event
- EventTarget
- MessagePort
- MessageChannel
- MessageEvent

to the set of global objects, since they are available now and behave
like they do in the browser.

Fixes: https://github.com/nodejs/node/issues/35495

PR-URL: https://github.com/nodejs/node/pull/35496
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Joyee Cheung 
Reviewed-By: Myles Borins 
Reviewed-By: Shelley Vohr 
Reviewed-By: Michael Dawson 
Reviewed-By: Khaidi Chu

src: add maybe versions of EmitExit and EmitBeforeExit

2020-10-11T00:20:53+00:00

This addresses a TODO comment, and removes invalid `.ToLocalChecked()`
calls from our code base.

PR-URL: https://github.com/nodejs/node/pull/35486
Reviewed-By: James M Snell

src: add check against non-weak BaseObjects at process exit

2020-10-07T08:54:34+00:00

When a process exits cleanly, i.e. because the event loop ends up
without things to wait for, the Node.js objects that are left on
the heap should be:

 1. weak, i.e. ready for garbage collection once no longer
    referenced, or
 2. detached, i.e. scheduled for destruction once no longer
    referenced, or
 3. an unrefed libuv handle, i.e. does not keep the event loop
    alive, or
 4. an inactive libuv handle (essentially the same here)

There are a few exceptions to this rule, but generally,
if there are C++-backed Node.js objects on the heap
that do not fall into the above categories, we may be looking
at a potential memory leak. Most likely, the cause is a missing
`MakeWeak()` call on the corresponding object.

In order to avoid this kind of problem, we check the list
of BaseObjects for these criteria. In this commit, we only do so
when explicitly instructed to or when in debug mode
(where --verify-base-objects is always-on).

In particular, this avoids the kinds of memory leak issues
that were fixed in the PRs referenced below.

Refs: https://github.com/nodejs/node/pull/35488
Refs: https://github.com/nodejs/node/pull/35487
Refs: https://github.com/nodejs/node/pull/35481

PR-URL: https://github.com/nodejs/node/pull/35490
Reviewed-By: James M Snell 
Reviewed-By: Matteo Collina 
Reviewed-By: Rich Trott 
Reviewed-By: Joyee Cheung 
Reviewed-By: Benjamin Gruenbaum

perf_hooks: add idleTime and event loop util

2020-08-29T14:02:31+00:00

Use uv_metrics_idle_time() to return a high resolution millisecond timer
of the amount of time the event loop has been idle since it was
initialized.

Include performance.eventLoopUtilization() API to handle the math of
calculating the idle and active times. This has been added to prevent
accidental miscalculations of the event loop utilization. Such as not
taking into consideration offsetting nodeTiming.loopStart or timing
differences when being called from a Worker thread.

PR-URL: https://github.com/nodejs/node/pull/34938
Reviewed-By: James M Snell 
Reviewed-By: Adrian Estrada 
Reviewed-By: Juan José Arboleda 
Reviewed-By: Matteo Collina 
Reviewed-By: Stephen Belanger 
Reviewed-By: Gireesh Punathil 
Reviewed-By: Gerhard Stöbich

src: prefer C++ empty() in boolean expressions

2020-08-11T20:22:04+00:00

PR-URL: https://github.com/nodejs/node/pull/34432
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Jiawen Geng 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Gus Caplan 
Reviewed-By: David Carlier 
Reviewed-By: James M Snell 
Reviewed-By: Trivikram Kamat 
Reviewed-By: Franziska Hinkelmann

worker: add option to track unmanaged file descriptors

2020-07-14T13:07:20+00:00

Add a public option for Workers which adds tracking for raw
file descriptors, as currently, those resources are not cleaned
up, unlike e.g. `FileHandle`s.

PR-URL: https://github.com/nodejs/node/pull/34303
Reviewed-By: James M Snell 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Benjamin Gruenbaum

src: disallow JS execution inside FreeEnvironment

2020-06-25T00:43:29+00:00

This addresses a TODO comment, and aligns the behavior between
worker threads and the main thread.

The primary motivation for this change is to more strictly enforce
the invariant that no JS runs after the `'exit'` event is emitted.

PR-URL: https://github.com/nodejs/node/pull/33874
Reviewed-By: Gus Caplan 
Reviewed-By: James M Snell 
Reviewed-By: Shelley Vohr