delta/node-new.git/src/node_watchdog.h, branch crypto_set_integer_macro

vm: fix race condition with timeout param

2017-05-23T19:00:40+00:00

This fixes a race condition in the watchdog timer used for vm timeouts.
The condition would terminate the main stack's execution instead of the
code running under the sandbox.

PR-URL: https://github.com/nodejs/node/pull/13074
Reviewed-By: Anna Henningsen

meta: restore original copyright header

2017-03-10T19:23:48+00:00

A prior io.js era commit inappropriately removed the
original copyright statements from the source. This
restores those in any files still remaining from that
edit.

Ref: https://github.com/nodejs/TSC/issues/174
Ref: https://github.com/nodejs/node/pull/10599
PR-URL: https://github.com/nodejs/node/pull/10155

Note: This PR was required, reviewed-by and approved
by the Node.js Foundation Legal Committee and the TSC.
There is no `Approved-By:` meta data.

watchdog: add flag to mark handler as disabled

2016-12-23T02:32:08+00:00

Adds flags that marks WinCtrlCHandlerRoutine as disabled instead of
removing it. Trying to remove the controller from the controller
handle itself leads to deadlock.

PR-URL: https://github.com/nodejs/node/pull/10248
Reviewed-By: Anna Henningsen

test,util: fix flaky test-util-sigint-watchdog

2016-08-11T16:42:41+00:00

Fix parallel/test-util-sigint-watchdog by polling until the
signal has definitely been received instead of just using a timeout.

Fixes: https://github.com/nodejs/node/issues/7919
PR-URL: https://github.com/nodejs/node/pull/7933
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: use RAII for mutexes in node_watchdog.cc

2016-08-11T16:42:37+00:00

PR-URL: https://github.com/nodejs/node/pull/7933
Reviewed-By: James M Snell 
Reviewed-By: Colin Ihrig

src: fix whitespace/indent cpplint warnings

2016-06-28T19:21:21+00:00

PR-URL: https://github.com/nodejs/node/pull/7462
Reviewed-By: Trevor Norris

src: fix whitespace/blank_line cpplint warnings

2016-06-28T19:21:21+00:00

PR-URL: https://github.com/nodejs/node/pull/7462
Reviewed-By: Trevor Norris

vm: test for abort condition of current invocation

2016-06-25T03:50:26+00:00

When a vm script aborted after a timeout/signal interruption, test
whether the local timeout/signal watchdog was responsible for
terminating the execution.

Without this, when a shorter timer from an outer `vm.run*` invocation
fires before an inner timeout, the inner timeout would throw an error
instead of the outer one, but because it did not witness the timeout
itself, it would assume the termination was the result of a signal
interruption.

PR-URL: https://github.com/nodejs/node/pull/7373
Reviewed-By: Ben Noordhuis 
Reviewed-By: Colin Ihrig

vm: add ability to break on sigint/ctrl+c

2016-06-18T18:44:16+00:00

- Adds the `breakEvalOnSigint` option to `vm.runIn(This)Context`.
  This uses a watchdog thread to wait for SIGINT and generally works
  just like the existing `timeout` option.

- Adds a method to the existing timer-based watchdog to check if it
  stopped regularly or by running into the timeout. This is used to
  tell a SIGINT abort from a timer-based one.

- Adds (internal) `process._{start,stop}SigintWatchdog` methods to
  start/stop the watchdog thread used by the above option manually.
  This will be used in the REPL to set up SIGINT handling before
  entering terminal raw mode, so that there is no time window in
  which Ctrl+C fully aborts the process.

PR-URL: https://github.com/nodejs/node/pull/6635
Reviewed-By: Ben Noordhuis

src: add include guards to internal headers

2016-05-25T07:54:24+00:00

For consistency with the newly added src/base64.h header, check that
NODE_WANT_INTERNALS is defined and set in internal headers.

PR-URL: https://github.com/nodejs/node/pull/6948
Refs: https://github.com/nodejs/node/pull/6910
Reviewed-By: Fedor Indutny 
Reviewed-By: James M Snell 
Reviewed-By: Trevor Norris