delta/node-new.git/src/node_watchdog.cc, branch try_Python3_on_macOS

src: do not use pointer for loop in node_watchdog

2019-06-13T03:55:25+00:00

PR-URL: https://github.com/nodejs/node/pull/28020
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ben Noordhuis 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott

src: remove env-inl.h from header files

2019-05-23T15:51:41+00:00

Inline headers should only be included into the .cc files that use them.

PR-URL: https://github.com/nodejs/node/pull/27755
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: James M Snell

src: enable V8's WASM trap handlers

2019-05-16T17:52:53+00:00

This uses SIGSEGV handlers to catch WASM out of bound (OOB) memory
accesses instead of inserting OOB checks inline, resulting in a 25%-30%
speed increase.

Note that installing a custom SIGSEGV handler will break this, resulting
in potentially scary behaviour.

Refs: https://github.com/nodejs/node/issues/14927

PR-URL: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis 
Reviewed-By: Joyee Cheung 
Reviewed-By: Anna Henningsen

src: remove util-inl.h from header files

2019-05-13T20:43:26+00:00

Its intended that *-inl.h header files are only included into the src
files that call the inline methods. Explicitly include it into the files
that need it.

PR-URL: https://github.com/nodejs/node/pull/27631
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig

src: make watchdog async callback a lambda

2019-02-08T07:31:25+00:00

`Watchdog::Async` features only once for the
async callback, so make it a lambda.

PR-URL: https://github.com/nodejs/node/pull/25945
Reviewed-By: James M Snell 
Reviewed-By: Anna Henningsen 
Reviewed-By: Colin Ihrig

src: do not alias new and old signal masks

2018-12-07T18:13:51+00:00

In recent gcc, -Wrestrict warns when an argument passed to a
restrict-qualified parameter aliases with another argument.

PR-URL: https://github.com/nodejs/node/pull/24810
Reviewed-By: Richard Lau

src: move error handling code into node_errors.cc

2018-11-06T12:58:40+00:00

Move the following code into a new node_errors.cc file and
declare them in node_errors.h for clarity and make it possible
to include them with node_errors.h.

- AppendExceptionLine()
- DecorateErrorStack()
- FatalError()
- OnFatalError()
- PrintErrorString()
- FatalException()
- ReportException()
- FatalTryCatch

And move the following definitions (declared elsewhere than
node_errors.h) to node_errors.cc:

- Abort() (in util.h)
- Assert() (in util.h)

PR-URL: https://github.com/nodejs/node/pull/24058
Reviewed-By: Refael Ackermann 
Reviewed-By: Daniel Bevenius

worker,src: display remaining handles if `uv_loop_close` fails

2018-06-13T10:23:36+00:00

Right now, we crash the process if there are handles remaining
on the event loop when we exit (except for the main thread).

This does not provide a lot of information about causes, though;
in particular, we don’t show which handles are pending and
who own them.

This patch adds debug output to these cases to help with the
situation.

PR-URL: https://github.com/nodejs/node/pull/21238
Reviewed-By: Tiancheng "Timothy" Gu 
Reviewed-By: James M Snell 
Reviewed-By: Gus Caplan 
Reviewed-By: Ben Noordhuis 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Colin Ihrig

src: refactor `#include` handling

2017-09-14T15:38:38+00:00

`node_internals.h` already includes the most common headers,
so double includes can be avoided in a lot of cases. Also don’t include
`node_internals.h` from `node.h` implicitly anymore, as that is mostly
unnecessary.

PR-URL: https://github.com/nodejs/node/pull/14697
Reviewed-By: Tobias Nießen 
Reviewed-By: Refael Ackermann 
Reviewed-By: James M Snell

vm: fix race condition with timeout param

2017-05-23T19:00:40+00:00

This fixes a race condition in the watchdog timer used for vm timeouts.
The condition would terminate the main stack's execution instead of the
code running under the sandbox.

PR-URL: https://github.com/nodejs/node/pull/13074
Reviewed-By: Anna Henningsen